* [PATCH] pinctrl: bcm63xx: fix unmet dependency on REGMAP for GPIO_REGMAP
@ 2022-01-17 6:25 Julian Braha
2022-01-30 1:45 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Julian Braha @ 2022-01-17 6:25 UTC (permalink / raw)
To: linus.walleij, jonas.gorski, noltari, f.fainelli, rdunlap, rafal
Cc: linux-gpio, fazilyildiran
When PINCTRL_BCM63XX is selected,
and REGMAP is not selected,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for GPIO_REGMAP
Depends on [n]: GPIOLIB [=y] && REGMAP [=n]
Selected by [y]:
- PINCTRL_BCM63XX [=y] && PINCTRL [=y]
This is because PINCTRL_BCM63XX
selects GPIO_REGMAP without selecting or depending on
REGMAP, despite GPIO_REGMAP depending on REGMAP.
This unmet dependency bug was detected by Kismet,
a static analysis tool for Kconfig. Please advise
if this is not the appropriate solution.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
drivers/pinctrl/bcm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/bcm/Kconfig b/drivers/pinctrl/bcm/Kconfig
index 5123f4c33854..ac1e400bbbac 100644
--- a/drivers/pinctrl/bcm/Kconfig
+++ b/drivers/pinctrl/bcm/Kconfig
@@ -35,6 +35,7 @@ config PINCTRL_BCM63XX
select PINCONF
select GENERIC_PINCONF
select GPIOLIB
+ select REGMAP
select GPIO_REGMAP
config PINCTRL_BCM6318
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: bcm63xx: fix unmet dependency on REGMAP for GPIO_REGMAP
2022-01-17 6:25 [PATCH] pinctrl: bcm63xx: fix unmet dependency on REGMAP for GPIO_REGMAP Julian Braha
@ 2022-01-30 1:45 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2022-01-30 1:45 UTC (permalink / raw)
To: Julian Braha
Cc: jonas.gorski, noltari, f.fainelli, rdunlap, rafal, linux-gpio,
fazilyildiran
On Mon, Jan 17, 2022 at 7:25 AM Julian Braha <julianbraha@gmail.com> wrote:
> When PINCTRL_BCM63XX is selected,
> and REGMAP is not selected,
> Kbuild gives the following warning:
>
> WARNING: unmet direct dependencies detected for GPIO_REGMAP
> Depends on [n]: GPIOLIB [=y] && REGMAP [=n]
> Selected by [y]:
> - PINCTRL_BCM63XX [=y] && PINCTRL [=y]
>
> This is because PINCTRL_BCM63XX
> selects GPIO_REGMAP without selecting or depending on
> REGMAP, despite GPIO_REGMAP depending on REGMAP.
>
> This unmet dependency bug was detected by Kismet,
> a static analysis tool for Kconfig. Please advise
> if this is not the appropriate solution.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-30 1:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-17 6:25 [PATCH] pinctrl: bcm63xx: fix unmet dependency on REGMAP for GPIO_REGMAP Julian Braha
2022-01-30 1:45 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).