* [PATCH] gpio: idt3243x: Fix signedness bug in probe
@ 2022-01-20 5:20 Dan Carpenter
2022-01-20 8:07 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-01-20 5:20 UTC (permalink / raw)
To: Linus Walleij, Miaoqian Lin
Cc: Bartosz Golaszewski, linux-gpio, kernel-janitors
The "parent_irq" variable needs to be signed for the error handling to
work.
Fixes: 30fee1d7462a ("gpio: idt3243x: Fix IRQ check in idt_gpio_probe")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpio/gpio-idt3243x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-idt3243x.c b/drivers/gpio/gpio-idt3243x.c
index 08493b05be2d..52b8b72ded77 100644
--- a/drivers/gpio/gpio-idt3243x.c
+++ b/drivers/gpio/gpio-idt3243x.c
@@ -132,7 +132,7 @@ static int idt_gpio_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct gpio_irq_chip *girq;
struct idt_gpio_ctrl *ctrl;
- unsigned int parent_irq;
+ int parent_irq;
int ngpios;
int ret;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: idt3243x: Fix signedness bug in probe
2022-01-20 5:20 [PATCH] gpio: idt3243x: Fix signedness bug in probe Dan Carpenter
@ 2022-01-20 8:07 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2022-01-20 8:07 UTC (permalink / raw)
To: Dan Carpenter
Cc: Linus Walleij, Miaoqian Lin, open list:GPIO SUBSYSTEM,
kernel-janitors
On Thu, Jan 20, 2022 at 6:20 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> The "parent_irq" variable needs to be signed for the error handling to
> work.
>
> Fixes: 30fee1d7462a ("gpio: idt3243x: Fix IRQ check in idt_gpio_probe")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpio/gpio-idt3243x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-idt3243x.c b/drivers/gpio/gpio-idt3243x.c
> index 08493b05be2d..52b8b72ded77 100644
> --- a/drivers/gpio/gpio-idt3243x.c
> +++ b/drivers/gpio/gpio-idt3243x.c
> @@ -132,7 +132,7 @@ static int idt_gpio_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct gpio_irq_chip *girq;
> struct idt_gpio_ctrl *ctrl;
> - unsigned int parent_irq;
> + int parent_irq;
> int ngpios;
> int ret;
>
> --
> 2.20.1
>
Hi Dan!
Fixes for this and the same issue in mpc8xxx have already been fixed by Yang Li.
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-20 8:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-20 5:20 [PATCH] gpio: idt3243x: Fix signedness bug in probe Dan Carpenter
2022-01-20 8:07 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).