* [PATCH v1 1/1] gpiolib: Use list_first_entry()/list_last_entry()
@ 2022-03-07 10:54 Andy Shevchenko
2022-03-08 8:53 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2022-03-07 10:54 UTC (permalink / raw)
To: Bartosz Golaszewski, Andy Shevchenko, linux-gpio, linux-kernel
Cc: Linus Walleij
Use list_first_entry()/list_last_entry() instead of open coded variants.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpio/gpiolib.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 002bf4b1616b..f5e7443208d4 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -262,14 +262,14 @@ static int gpiodev_add_to_list(struct gpio_device *gdev)
return 0;
}
- next = list_entry(gpio_devices.next, struct gpio_device, list);
+ next = list_first_entry(&gpio_devices, struct gpio_device, list);
if (gdev->base + gdev->ngpio <= next->base) {
/* add before first entry */
list_add(&gdev->list, &gpio_devices);
return 0;
}
- prev = list_entry(gpio_devices.prev, struct gpio_device, list);
+ prev = list_last_entry(&gpio_devices, struct gpio_device, list);
if (prev->base + prev->ngpio <= gdev->base) {
/* add behind last entry */
list_add_tail(&gdev->list, &gpio_devices);
@@ -4426,7 +4426,7 @@ static void *gpiolib_seq_next(struct seq_file *s, void *v, loff_t *pos)
if (list_is_last(&gdev->list, &gpio_devices))
ret = NULL;
else
- ret = list_entry(gdev->list.next, struct gpio_device, list);
+ ret = list_first_entry(&gdev->list, struct gpio_device, list);
spin_unlock_irqrestore(&gpio_lock, flags);
s->private = "\n";
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1 1/1] gpiolib: Use list_first_entry()/list_last_entry()
2022-03-07 10:54 [PATCH v1 1/1] gpiolib: Use list_first_entry()/list_last_entry() Andy Shevchenko
@ 2022-03-08 8:53 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2022-03-08 8:53 UTC (permalink / raw)
To: Andy Shevchenko
Cc: open list:GPIO SUBSYSTEM, Linux Kernel Mailing List,
Linus Walleij
On Mon, Mar 7, 2022 at 11:54 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Use list_first_entry()/list_last_entry() instead of open coded variants.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/gpio/gpiolib.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 002bf4b1616b..f5e7443208d4 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -262,14 +262,14 @@ static int gpiodev_add_to_list(struct gpio_device *gdev)
> return 0;
> }
>
> - next = list_entry(gpio_devices.next, struct gpio_device, list);
> + next = list_first_entry(&gpio_devices, struct gpio_device, list);
> if (gdev->base + gdev->ngpio <= next->base) {
> /* add before first entry */
> list_add(&gdev->list, &gpio_devices);
> return 0;
> }
>
> - prev = list_entry(gpio_devices.prev, struct gpio_device, list);
> + prev = list_last_entry(&gpio_devices, struct gpio_device, list);
> if (prev->base + prev->ngpio <= gdev->base) {
> /* add behind last entry */
> list_add_tail(&gdev->list, &gpio_devices);
> @@ -4426,7 +4426,7 @@ static void *gpiolib_seq_next(struct seq_file *s, void *v, loff_t *pos)
> if (list_is_last(&gdev->list, &gpio_devices))
> ret = NULL;
> else
> - ret = list_entry(gdev->list.next, struct gpio_device, list);
> + ret = list_first_entry(&gdev->list, struct gpio_device, list);
> spin_unlock_irqrestore(&gpio_lock, flags);
>
> s->private = "\n";
> --
> 2.34.1
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-08 8:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-07 10:54 [PATCH v1 1/1] gpiolib: Use list_first_entry()/list_last_entry() Andy Shevchenko
2022-03-08 8:53 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).