* [PATCH] pinctrl: mediatek: Fix missing of_node_put() in mtk_pctrl_init
@ 2022-03-08 7:11 Miaoqian Lin
2022-03-10 16:06 ` AngeloGioacchino Del Regno
2022-03-15 0:21 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Miaoqian Lin @ 2022-03-08 7:11 UTC (permalink / raw)
To: Sean Wang, Linus Walleij, Matthias Brugger, Hongzhou Yang,
linux-mediatek, linux-gpio, linux-arm-kernel, linux-kernel
Cc: linmq006
The device_node pointer is returned by of_parse_phandle() with refcount
incremented. We should use of_node_put() on it when done.
Fixes: a6df410d420a ("pinctrl: mediatek: Add Pinctrl/GPIO driver for mt8135.")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
index 5f7c421ab6e7..334cb85855a9 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
@@ -1038,6 +1038,7 @@ int mtk_pctrl_init(struct platform_device *pdev,
node = of_parse_phandle(np, "mediatek,pctl-regmap", 0);
if (node) {
pctl->regmap1 = syscon_node_to_regmap(node);
+ of_node_put(node);
if (IS_ERR(pctl->regmap1))
return PTR_ERR(pctl->regmap1);
} else if (regmap) {
@@ -1051,6 +1052,7 @@ int mtk_pctrl_init(struct platform_device *pdev,
node = of_parse_phandle(np, "mediatek,pctl-regmap", 1);
if (node) {
pctl->regmap2 = syscon_node_to_regmap(node);
+ of_node_put(node);
if (IS_ERR(pctl->regmap2))
return PTR_ERR(pctl->regmap2);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: mediatek: Fix missing of_node_put() in mtk_pctrl_init
2022-03-08 7:11 [PATCH] pinctrl: mediatek: Fix missing of_node_put() in mtk_pctrl_init Miaoqian Lin
@ 2022-03-10 16:06 ` AngeloGioacchino Del Regno
2022-03-15 0:21 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-03-10 16:06 UTC (permalink / raw)
To: Miaoqian Lin, Sean Wang, Linus Walleij, Matthias Brugger,
Hongzhou Yang, linux-mediatek, linux-gpio, linux-arm-kernel,
linux-kernel
Il 08/03/22 08:11, Miaoqian Lin ha scritto:
> The device_node pointer is returned by of_parse_phandle() with refcount
> incremented. We should use of_node_put() on it when done.
>
> Fixes: a6df410d420a ("pinctrl: mediatek: Add Pinctrl/GPIO driver for mt8135.")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Thanks!
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> index 5f7c421ab6e7..334cb85855a9 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> @@ -1038,6 +1038,7 @@ int mtk_pctrl_init(struct platform_device *pdev,
> node = of_parse_phandle(np, "mediatek,pctl-regmap", 0);
> if (node) {
> pctl->regmap1 = syscon_node_to_regmap(node);
> + of_node_put(node);
> if (IS_ERR(pctl->regmap1))
> return PTR_ERR(pctl->regmap1);
> } else if (regmap) {
> @@ -1051,6 +1052,7 @@ int mtk_pctrl_init(struct platform_device *pdev,
> node = of_parse_phandle(np, "mediatek,pctl-regmap", 1);
> if (node) {
> pctl->regmap2 = syscon_node_to_regmap(node);
> + of_node_put(node);
> if (IS_ERR(pctl->regmap2))
> return PTR_ERR(pctl->regmap2);
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: mediatek: Fix missing of_node_put() in mtk_pctrl_init
2022-03-08 7:11 [PATCH] pinctrl: mediatek: Fix missing of_node_put() in mtk_pctrl_init Miaoqian Lin
2022-03-10 16:06 ` AngeloGioacchino Del Regno
@ 2022-03-15 0:21 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2022-03-15 0:21 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Sean Wang, Matthias Brugger, Hongzhou Yang, linux-mediatek,
linux-gpio, linux-arm-kernel, linux-kernel
On Tue, Mar 8, 2022 at 8:12 AM Miaoqian Lin <linmq006@gmail.com> wrote:
> The device_node pointer is returned by of_parse_phandle() with refcount
> incremented. We should use of_node_put() on it when done.
>
> Fixes: a6df410d420a ("pinctrl: mediatek: Add Pinctrl/GPIO driver for mt8135.")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-15 0:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-08 7:11 [PATCH] pinctrl: mediatek: Fix missing of_node_put() in mtk_pctrl_init Miaoqian Lin
2022-03-10 16:06 ` AngeloGioacchino Del Regno
2022-03-15 0:21 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).