From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-gpio@vger.kernel.org
Subject: Re: [libgpiod v2][PATCH v4 0/2] libgpiod v2: rewrite tests for the C library
Date: Tue, 8 Mar 2022 18:13:51 +0800 [thread overview]
Message-ID: <20220308101351.GA59118@sol> (raw)
In-Reply-To: <20220307113401.224584-1-brgl@bgdev.pl>
On Mon, Mar 07, 2022 at 12:33:59PM +0100, Bartosz Golaszewski wrote:
> v1 -> v2:
> - drop applied patches
> - improve documentation
> - skip offsets that are overridden in line_config but not actually requested
>
> v2 -> v3:
> - add a patch adding an enum for line values
> - rework the mechanism for retrieving overrides
> - add new "constructors" for line_config
> - incorporate part of Kent's points in the documentation
> - a bunch of improvements to tests as per Kent's reviews
>
> v3 -> v4:
> - drop the new constructors added in v3
> - improve the docs for override interfaces
> - use NUM_OVERRIDES_MAX when referring to the max number of overrides
>
Series looks goods to me.
Reviewed-by: Kent Gibson <warthog618@gmail.com>
Cheers,
Kent.
> Bartosz Golaszewski (2):
> line-config: expose the override logic to users
> tests: rewrite core C tests using libgpiosim
>
> configure.ac | 8 +-
> include/gpiod.h | 573 ++++++++++++------
> lib/line-config.c | 808 ++++++++++++++++---------
> tests/Makefile.am | 22 +-
> tests/gpiod-test-helpers.c | 49 ++
> tests/gpiod-test-helpers.h | 139 +++++
> tests/gpiod-test-sim.c | 308 ++++++++++
> tests/gpiod-test-sim.h | 42 ++
> tests/gpiod-test.c | 233 +-------
> tests/gpiod-test.h | 83 +--
> tests/gpiosim/gpiosim.c | 1 +
> tests/mockup/Makefile.am | 11 -
> tests/mockup/gpio-mockup.c | 496 ----------------
> tests/mockup/gpio-mockup.h | 36 --
> tests/tests-chip.c | 282 ++++-----
> tests/tests-edge-event.c | 490 +++++++++++++++
> tests/tests-event.c | 908 ----------------------------
> tests/tests-info-event.c | 301 ++++++++++
> tests/tests-line-config.c | 457 ++++++++++++++
> tests/tests-line-info.c | 318 ++++++++++
> tests/tests-line-request.c | 526 ++++++++++++++++
> tests/tests-line.c | 1091 ----------------------------------
> tests/tests-misc.c | 80 ++-
> tests/tests-request-config.c | 90 +++
> tools/gpioget.c | 6 +-
> tools/gpiomon.c | 6 +-
> tools/gpioset.c | 9 +-
> 27 files changed, 3878 insertions(+), 3495 deletions(-)
> create mode 100644 tests/gpiod-test-helpers.c
> create mode 100644 tests/gpiod-test-helpers.h
> create mode 100644 tests/gpiod-test-sim.c
> create mode 100644 tests/gpiod-test-sim.h
> delete mode 100644 tests/mockup/Makefile.am
> delete mode 100644 tests/mockup/gpio-mockup.c
> delete mode 100644 tests/mockup/gpio-mockup.h
> create mode 100644 tests/tests-edge-event.c
> delete mode 100644 tests/tests-event.c
> create mode 100644 tests/tests-info-event.c
> create mode 100644 tests/tests-line-config.c
> create mode 100644 tests/tests-line-info.c
> create mode 100644 tests/tests-line-request.c
> delete mode 100644 tests/tests-line.c
> create mode 100644 tests/tests-request-config.c
>
> --
> 2.30.1
>
prev parent reply other threads:[~2022-03-08 10:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 11:33 [libgpiod v2][PATCH v4 0/2] libgpiod v2: rewrite tests for the C library Bartosz Golaszewski
2022-03-07 11:34 ` [libgpiod v2][PATCH v4 1/2] line-config: expose the override logic to users Bartosz Golaszewski
2022-03-07 11:34 ` [libgpiod v2][PATCH v4 2/2] tests: rewrite core C tests using libgpiosim Bartosz Golaszewski
2022-03-08 10:13 ` Kent Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220308101351.GA59118@sol \
--to=warthog618@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).