* [PATCH AUTOSEL 5.10 10/12] gpio: Revert regression in sysfs-gpio (gpiolib.c) [not found] <20220316141636.248324-1-sashal@kernel.org> @ 2022-03-16 14:16 ` Sasha Levin 2022-03-16 16:06 ` Linus Walleij 0 siblings, 1 reply; 4+ messages in thread From: Sasha Levin @ 2022-03-16 14:16 UTC (permalink / raw) To: linux-kernel, stable Cc: Marcelo Roberto Jimenez, Bartosz Golaszewski, Sasha Levin, linus.walleij, linux-gpio From: Marcelo Roberto Jimenez <marcelo.jimenez@gmail.com> [ Upstream commit fc328a7d1fcce263db0b046917a66f3aa6e68719 ] Some GPIO lines have stopped working after the patch commit 2ab73c6d8323f ("gpio: Support GPIO controllers without pin-ranges") And this has supposedly been fixed in the following patches commit 89ad556b7f96a ("gpio: Avoid using pin ranges with !PINCTRL") commit 6dbbf84603961 ("gpiolib: Don't free if pin ranges are not defined") But an erratic behavior where some GPIO lines work while others do not work has been introduced. This patch reverts those changes so that the sysfs-gpio interface works properly again. Signed-off-by: Marcelo Roberto Jimenez <marcelo.jimenez@gmail.com> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/gpio/gpiolib.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index af5bb8fedfea..ac69ec8fb37a 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1804,11 +1804,6 @@ static inline void gpiochip_irqchip_free_valid_mask(struct gpio_chip *gc) */ int gpiochip_generic_request(struct gpio_chip *gc, unsigned offset) { -#ifdef CONFIG_PINCTRL - if (list_empty(&gc->gpiodev->pin_ranges)) - return 0; -#endif - return pinctrl_gpio_request(gc->gpiodev->base + offset); } EXPORT_SYMBOL_GPL(gpiochip_generic_request); @@ -1820,11 +1815,6 @@ EXPORT_SYMBOL_GPL(gpiochip_generic_request); */ void gpiochip_generic_free(struct gpio_chip *gc, unsigned offset) { -#ifdef CONFIG_PINCTRL - if (list_empty(&gc->gpiodev->pin_ranges)) - return; -#endif - pinctrl_gpio_free(gc->gpiodev->base + offset); } EXPORT_SYMBOL_GPL(gpiochip_generic_free); -- 2.34.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH AUTOSEL 5.10 10/12] gpio: Revert regression in sysfs-gpio (gpiolib.c) 2022-03-16 14:16 ` [PATCH AUTOSEL 5.10 10/12] gpio: Revert regression in sysfs-gpio (gpiolib.c) Sasha Levin @ 2022-03-16 16:06 ` Linus Walleij 2022-03-16 16:40 ` Sasha Levin 0 siblings, 1 reply; 4+ messages in thread From: Linus Walleij @ 2022-03-16 16:06 UTC (permalink / raw) To: Sasha Levin Cc: linux-kernel, stable, Marcelo Roberto Jimenez, Bartosz Golaszewski, linux-gpio On Wed, Mar 16, 2022 at 3:17 PM Sasha Levin <sashal@kernel.org> wrote: > From: Marcelo Roberto Jimenez <marcelo.jimenez@gmail.com> > > [ Upstream commit fc328a7d1fcce263db0b046917a66f3aa6e68719 ] > > Some GPIO lines have stopped working after the patch > commit 2ab73c6d8323f ("gpio: Support GPIO controllers without pin-ranges") > > And this has supposedly been fixed in the following patches > commit 89ad556b7f96a ("gpio: Avoid using pin ranges with !PINCTRL") > commit 6dbbf84603961 ("gpiolib: Don't free if pin ranges are not defined") > > But an erratic behavior where some GPIO lines work while others do not work > has been introduced. > > This patch reverts those changes so that the sysfs-gpio interface works > properly again. > > Signed-off-by: Marcelo Roberto Jimenez <marcelo.jimenez@gmail.com> > Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> > Signed-off-by: Sasha Levin <sashal@kernel.org> I think you should not apply this for stable, because we will revert the revert. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH AUTOSEL 5.10 10/12] gpio: Revert regression in sysfs-gpio (gpiolib.c) 2022-03-16 16:06 ` Linus Walleij @ 2022-03-16 16:40 ` Sasha Levin 2022-03-16 23:41 ` Linus Walleij 0 siblings, 1 reply; 4+ messages in thread From: Sasha Levin @ 2022-03-16 16:40 UTC (permalink / raw) To: Linus Walleij Cc: linux-kernel, stable, Marcelo Roberto Jimenez, Bartosz Golaszewski, linux-gpio On Wed, Mar 16, 2022 at 05:06:47PM +0100, Linus Walleij wrote: >On Wed, Mar 16, 2022 at 3:17 PM Sasha Levin <sashal@kernel.org> wrote: > >> From: Marcelo Roberto Jimenez <marcelo.jimenez@gmail.com> >> >> [ Upstream commit fc328a7d1fcce263db0b046917a66f3aa6e68719 ] >> >> Some GPIO lines have stopped working after the patch >> commit 2ab73c6d8323f ("gpio: Support GPIO controllers without pin-ranges") >> >> And this has supposedly been fixed in the following patches >> commit 89ad556b7f96a ("gpio: Avoid using pin ranges with !PINCTRL") >> commit 6dbbf84603961 ("gpiolib: Don't free if pin ranges are not defined") >> >> But an erratic behavior where some GPIO lines work while others do not work >> has been introduced. >> >> This patch reverts those changes so that the sysfs-gpio interface works >> properly again. >> >> Signed-off-by: Marcelo Roberto Jimenez <marcelo.jimenez@gmail.com> >> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> >> Signed-off-by: Sasha Levin <sashal@kernel.org> > > >I think you should not apply this for stable, because we will revert the revert. Okay, I'll give it a week to soak and if the revert is in by then I can just pick it too for the sake of completeness. -- Thanks, Sasha ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH AUTOSEL 5.10 10/12] gpio: Revert regression in sysfs-gpio (gpiolib.c) 2022-03-16 16:40 ` Sasha Levin @ 2022-03-16 23:41 ` Linus Walleij 0 siblings, 0 replies; 4+ messages in thread From: Linus Walleij @ 2022-03-16 23:41 UTC (permalink / raw) To: Sasha Levin Cc: linux-kernel, stable, Marcelo Roberto Jimenez, Bartosz Golaszewski, linux-gpio On Wed, Mar 16, 2022 at 5:40 PM Sasha Levin <sashal@kernel.org> wrote: > On Wed, Mar 16, 2022 at 05:06:47PM +0100, Linus Walleij wrote: > >On Wed, Mar 16, 2022 at 3:17 PM Sasha Levin <sashal@kernel.org> wrote: > > > >> From: Marcelo Roberto Jimenez <marcelo.jimenez@gmail.com> > >> > >> [ Upstream commit fc328a7d1fcce263db0b046917a66f3aa6e68719 ] > >> > >> Some GPIO lines have stopped working after the patch > >> commit 2ab73c6d8323f ("gpio: Support GPIO controllers without pin-ranges") > >> > >> And this has supposedly been fixed in the following patches > >> commit 89ad556b7f96a ("gpio: Avoid using pin ranges with !PINCTRL") > >> commit 6dbbf84603961 ("gpiolib: Don't free if pin ranges are not defined") > >> > >> But an erratic behavior where some GPIO lines work while others do not work > >> has been introduced. > >> > >> This patch reverts those changes so that the sysfs-gpio interface works > >> properly again. > >> > >> Signed-off-by: Marcelo Roberto Jimenez <marcelo.jimenez@gmail.com> > >> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> > >> Signed-off-by: Sasha Levin <sashal@kernel.org> > > > > > >I think you should not apply this for stable, because we will revert the revert. > > Okay, I'll give it a week to soak and if the revert is in by then I can > just pick it too for the sake of completeness. The revert of the revert is already in Linus' tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=56e337f2cf1326323844927a04e9dbce9a244835 Yours, Linus Walleij ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-16 23:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220316141636.248324-1-sashal@kernel.org>
2022-03-16 14:16 ` [PATCH AUTOSEL 5.10 10/12] gpio: Revert regression in sysfs-gpio (gpiolib.c) Sasha Levin
2022-03-16 16:06 ` Linus Walleij
2022-03-16 16:40 ` Sasha Levin
2022-03-16 23:41 ` Linus Walleij
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).