From: Bill Wendling <morbo@google.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Cc: Bill Wendling <morbo@google.com>
Subject: [PATCH] gpiolib: acpi: use correct format characters
Date: Wed, 16 Mar 2022 14:30:55 -0700 [thread overview]
Message-ID: <20220316213055.2351342-1-morbo@google.com> (raw)
When compiling with -Wformat, clang emits the following warning:
drivers/gpio/gpiolib-acpi.c:393:4: warning: format specifies type
'unsigned char' but the argument has type 'int' [-Wformat]
pin);
^~~
The types of these arguments are unconditionally defined, so this patch
updates the format character to the correct ones for ints and unsigned
ints.
Link: ClangBuiltLinux/linux#378
Signed-off-by: Bill Wendling <morbo@google.com>
---
drivers/gpio/gpiolib-acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index a5495ad31c9c..be6fb2ad2c4a 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -388,7 +388,7 @@ static acpi_status acpi_gpiochip_alloc_event(struct acpi_resource *ares,
if (pin <= 255) {
char ev_name[5];
- sprintf(ev_name, "_%c%02hhX",
+ sprintf(ev_name, "_%c%02X",
agpio->triggering == ACPI_EDGE_SENSITIVE ? 'E' : 'L',
pin);
if (ACPI_SUCCESS(acpi_get_handle(handle, ev_name, &evt_handle)))
--
2.35.1.723.g4982287a31-goog
next reply other threads:[~2022-03-16 21:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 21:30 Bill Wendling [this message]
2022-03-17 9:06 ` [PATCH] gpiolib: acpi: use correct format characters Andy Shevchenko
2022-03-17 9:12 ` Andy Shevchenko
2022-03-17 18:11 ` Nick Desaulniers
2022-03-18 14:03 ` Andy Shevchenko
2022-03-18 18:01 ` Nick Desaulniers
2022-03-18 18:25 ` Bill Wendling
2022-03-18 18:29 ` Nick Desaulniers
2022-03-18 18:33 ` Bill Wendling
2022-03-18 18:40 ` Linus Torvalds
2022-03-18 18:46 ` Bill Wendling
2022-03-18 18:31 ` Linus Torvalds
2022-03-19 22:22 ` [PATCH v2] " Bill Wendling
2022-03-19 22:54 ` Linus Torvalds
2022-03-19 23:21 ` Linus Torvalds
2022-03-21 10:07 ` Andy Shevchenko
2022-03-21 17:05 ` Linus Torvalds
2022-03-21 18:04 ` Bill Wendling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220316213055.2351342-1-morbo@google.com \
--to=morbo@google.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mika.westerberg@linux.intel.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).