From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Russell King <linux@armlinux.org.uk>,
linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH] gpio: mvebu: drop pwm base assignment
Date: Mon, 11 Apr 2022 08:48:19 +0200 [thread overview]
Message-ID: <20220411064819.bnfyqekd6yy45g6a@pengutronix.de> (raw)
In-Reply-To: <145383feecbe43f3bbd3e128143f7890f0314b3b.1649658220.git.baruch@tkos.co.il>
[-- Attachment #1: Type: text/plain, Size: 818 bytes --]
Hello Baruch,
On Mon, Apr 11, 2022 at 09:23:40AM +0300, Baruch Siach wrote:
> pwmchip_add() unconditionally assigns the base ID dynamically. Commit
> f9a8ee8c8bcd1 ("pwm: Always allocate PWM chip base ID dynamically")
> dropped all base assignment from drivers under drivers/pwm/. It missed
> this driver. Fix that.
>
> Fixes: f9a8ee8c8bcd1 ("pwm: Always allocate PWM chip base ID dynamically")
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Thanks for catching this.
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
There is another one in drivers/staging/greybus/pwm.c, will send a patch
shortly.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-04-11 6:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 6:23 [PATCH] gpio: mvebu: drop pwm base assignment Baruch Siach
2022-04-11 6:48 ` Uwe Kleine-König [this message]
2022-04-22 16:48 ` Thierry Reding
2022-04-22 22:18 ` Linus Walleij
2022-04-23 16:18 ` Uwe Kleine-König
2022-04-24 13:30 ` Linus Walleij
2022-05-02 8:47 ` Bartosz Golaszewski
2022-05-02 9:10 ` Baruch Siach
2022-05-02 9:30 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411064819.bnfyqekd6yy45g6a@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=baruch@tkos.co.il \
--cc=lee.jones@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).