From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Cosmin Tanislav <demonsingur@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-iio <linux-iio@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Cosmin Tanislav <cosmin.tanislav@analog.com>
Subject: Re: [PATCH v1 3/3] iio: adc: ad4130: add AD4130 driver
Date: Sat, 16 Apr 2022 16:07:25 +0100 [thread overview]
Message-ID: <20220416160725.51f0b8f0@jic23-huawei> (raw)
In-Reply-To: <CAHp75VeYX_ZWZPEUwpfaSGUGCayCaMapS-5MHhgT1r17Fqqoeg@mail.gmail.com>
> ...
>
> > >>>> + out:
> > >>>
> > >>> out_unlock: ?
> > >>> Ditto for similar cases.
> > >>
> > >> There's a single label in the function, and there's a mutex being
> > >> taken, and, logically, the mutex must be released on the exit path.
> > >> It's clear what the label is for to me.
> > >
> > > Wasn't clear to me until I went to the end of each of them (who
> > > guarantees that's the case for all of them?).
> >
> > Let's hope other people looking at that code will be able to figure out
> > what that label does then.
>
> OK. Let the maintainer decide.
Slight preference for giving the extra info of out_unlock, but not critical.
(note I haven't read the code yet so might change my mind :)
next prev parent reply other threads:[~2022-04-16 14:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 9:40 [PATCH v1 1/3] dt-bindings: iio: adc: add AD4130 Cosmin Tanislav
2022-04-13 9:40 ` [PATCH v1 2/3] iio: ABI: adc: ad4130: document filter_mode{,_available} Cosmin Tanislav
2022-04-13 14:51 ` Andy Shevchenko
2022-04-14 7:41 ` Cosmin Tanislav
2022-04-16 15:02 ` Jonathan Cameron
2022-04-13 9:40 ` [PATCH v1 3/3] iio: adc: ad4130: add AD4130 driver Cosmin Tanislav
2022-04-13 15:41 ` Andy Shevchenko
2022-04-14 11:06 ` Cosmin Tanislav
2022-04-14 13:45 ` Andy Shevchenko
2022-04-14 14:53 ` Cosmin Tanislav
2022-04-14 15:37 ` Andy Shevchenko
2022-04-16 15:07 ` Jonathan Cameron [this message]
2022-04-16 16:21 ` Jonathan Cameron
2022-04-17 10:26 ` Cosmin Tanislav
2022-04-24 15:51 ` Jonathan Cameron
2022-04-13 12:26 ` [PATCH v1 1/3] dt-bindings: iio: adc: add AD4130 Rob Herring
2022-04-13 14:50 ` Andy Shevchenko
2022-04-16 15:00 ` Jonathan Cameron
2022-04-17 10:16 ` Cosmin Tanislav
2022-04-24 16:05 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220416160725.51f0b8f0@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=cosmin.tanislav@analog.com \
--cc=demonsingur@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).