From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Tony Luck" <tony.luck@intel.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Wolfram Sang" <wsa@kernel.org>,
"Jean Delvare" <jdelvare@suse.de>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Łukasz Bartosik" <lb@semihalf.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Jonathan Yong" <jonathan.yong@intel.com>,
linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Cc: Borislav Petkov <bp@alien8.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
James Morse <james.morse@arm.com>,
Robert Richter <rric@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Peter Tyser <ptyser@xes-inc.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Mark Gross <markgross@kernel.org>
Subject: [PATCH v5 0/8] platform/x86: introduce p2sb_bar() helper
Date: Tue, 10 May 2022 18:14:43 +0300 [thread overview]
Message-ID: <20220510151451.85561-1-andriy.shevchenko@linux.intel.com> (raw)
There are a few users and at least one more is coming (*1) that would
like to utilize P2SB mechanism of hiding and unhiding a device from
the PCI configuration space.
Here is the series to consolidate p2sb handling code for existing users
and provide a generic way for new comer(s).
It also includes a patch to enable GPIO controllers on Apollo Lake
when it's used with ABL bootloader w/o ACPI support (*2).
The patch that brings the helper ("platform/x86/intel: Add Primary to
Sideband (P2SB) bridge support") has a commit message that sheds a light
on what the P2SB is and why this is needed.
The changes made in v5 do not change the main idea and the functionality
in a big scale. What we need is probably one more retest done by Henning
(*3). I hope to have it merged to v5.19-rc1 that Siemens can develop
their changes based on this series (*4).
I have tested this on Apollo Lake platform (I'm able to see SPI NOR and
since we have an ACPI device for GPIO I do not see any attempts to recreate
one).
*1) One in this series, and one is a recent merge of the Simatic IPC drivers
*2) This patch can be postponed as Lee hasn't given his tag yet.
*3) Henning gave his tag and I dared to used it even against changed patch 1
*4) The changes were posted in between of v4 and v5 of this series, but need
more work.
Taking into account the *2) the series is ready to be merged via PDx86 tree.
Changes in v5:
- rewritten patch 1 to use pci_scan_single_device() (Lukas, Bjorn)
- rebased patch 2 on top of the new Intel SPI NOR codebase
- fixed a potential bug and rewritten resource filling in patch 5 (Lee)
- added many different tags in a few patches (Jean, Wolfram, Henning)
Changes in v4:
- added tag to the entire series (Hans)
- added tag to pin control patch (Mika)
- dropped PCI core changes (PCI core doesn't want modifications to be made)
- as a consequence of the above merged necessary bits into p2sb.c
- added a check that p2sb is really hidden (Hans)
- added EDAC patches (reviewed by maintainer internally)
Changes in v3:
- resent with cover letter
Changes in v2:
- added parentheses around bus in macros (Joe)
- added tag (Jean)
- fixed indentation and wrapping in the header (Christoph)
- moved out of PCI realm to PDx86 as the best common denominator (Bjorn)
- added a verbose commit message to explain P2SB thingy (Bjorn)
- converted first parameter from pci_dev to pci_bus
- made first two parameters (bus and devfn) optional (Henning, Lee)
- added Intel pin control patch to the series (Henning, Mika)
- fixed English style in the commit message of one of MFD patch (Lee)
- added tags to my MFD LPC ICH patches (Lee)
- used consistently (c) (Lee)
- made indexing for MFD cell and resource arrays (Lee)
- fixed the resource size in i801 (Jean)
Andy Shevchenko (6):
pinctrl: intel: Check against matching data instead of ACPI companion
mfd: lpc_ich: Factor out lpc_ich_enable_spi_write()
mfd: lpc_ich: Switch to generic p2sb_bar()
i2c: i801: convert to use common P2SB accessor
EDAC, pnd2: Use proper I/O accessors and address space annotation
EDAC, pnd2: convert to use common P2SB accessor
Jonathan Yong (1):
platform/x86/intel: Add Primary to Sideband (P2SB) bridge support
Tan Jui Nee (1):
mfd: lpc_ich: Add support for pinctrl in non-ACPI system
drivers/edac/Kconfig | 1 +
drivers/edac/pnd2_edac.c | 62 +++-------
drivers/i2c/busses/Kconfig | 1 +
drivers/i2c/busses/i2c-i801.c | 39 ++----
drivers/mfd/Kconfig | 1 +
drivers/mfd/lpc_ich.c | 161 +++++++++++++++++++------
drivers/pinctrl/intel/pinctrl-intel.c | 14 +--
drivers/platform/x86/intel/Kconfig | 12 ++
drivers/platform/x86/intel/Makefile | 2 +
drivers/platform/x86/intel/p2sb.c | 133 ++++++++++++++++++++
include/linux/platform_data/x86/p2sb.h | 28 +++++
11 files changed, 338 insertions(+), 116 deletions(-)
create mode 100644 drivers/platform/x86/intel/p2sb.c
create mode 100644 include/linux/platform_data/x86/p2sb.h
base-commit: 3bf222d317a20170ee17f082626c1e0f83537e13
--
2.35.1
next reply other threads:[~2022-05-10 15:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 15:14 Andy Shevchenko [this message]
2022-05-10 15:14 ` [PATCH v5 1/8] platform/x86/intel: Add Primary to Sideband (P2SB) bridge support Andy Shevchenko
2022-05-10 15:14 ` [PATCH v5 2/8] pinctrl: intel: Check against matching data instead of ACPI companion Andy Shevchenko
2022-05-10 15:14 ` [PATCH v5 3/8] mfd: lpc_ich: Factor out lpc_ich_enable_spi_write() Andy Shevchenko
2022-05-10 15:14 ` [PATCH v5 4/8] mfd: lpc_ich: Switch to generic p2sb_bar() Andy Shevchenko
2022-05-10 15:14 ` [PATCH v5 5/8] mfd: lpc_ich: Add support for pinctrl in non-ACPI system Andy Shevchenko
2022-05-12 9:53 ` Lee Jones
2022-05-10 15:14 ` [PATCH v5 6/8] i2c: i801: convert to use common P2SB accessor Andy Shevchenko
2022-05-10 15:14 ` [PATCH v5 7/8] EDAC, pnd2: Use proper I/O accessors and address space annotation Andy Shevchenko
2022-05-10 15:14 ` [PATCH v5 8/8] EDAC, pnd2: convert to use common P2SB accessor Andy Shevchenko
2022-05-11 16:08 ` [PATCH v5 0/8] platform/x86: introduce p2sb_bar() helper Hans de Goede
2022-05-11 18:01 ` Andy Shevchenko
2022-05-12 10:00 ` Lee Jones
2022-05-12 10:21 ` Andy Shevchenko
2022-05-12 16:04 ` Lee Jones
2022-05-12 9:55 ` Lee Jones
2022-05-12 10:45 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220510151451.85561-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=bp@alien8.de \
--cc=hdegoede@redhat.com \
--cc=hkallweit1@gmail.com \
--cc=james.morse@arm.com \
--cc=jdelvare@suse.com \
--cc=jdelvare@suse.de \
--cc=jonathan.yong@intel.com \
--cc=lb@semihalf.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mchehab@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=ptyser@xes-inc.com \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).