* [PATCH] gpio: pca9570: add pca9571 support
@ 2022-06-10 16:48 Lucas Stach
2022-06-13 10:03 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Lucas Stach @ 2022-06-10 16:48 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, Sungbo Eo
Cc: linux-gpio, devicetree, kernel, patchwork-lst
The PCA9571 very similar to the PCA9570, it only differs in the
number of GPIOs.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml | 1 +
drivers/gpio/gpio-pca9570.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
index 338c5312a106..1acaa0a3d35a 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
@@ -13,6 +13,7 @@ properties:
compatible:
enum:
- nxp,pca9570
+ - nxp,pca9571
reg:
maxItems: 1
diff --git a/drivers/gpio/gpio-pca9570.c b/drivers/gpio/gpio-pca9570.c
index cb2b2f735c15..ab2a652964ec 100644
--- a/drivers/gpio/gpio-pca9570.c
+++ b/drivers/gpio/gpio-pca9570.c
@@ -121,12 +121,14 @@ static int pca9570_probe(struct i2c_client *client)
static const struct i2c_device_id pca9570_id_table[] = {
{ "pca9570", 4 },
+ { "pca9571", 8 },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(i2c, pca9570_id_table);
static const struct of_device_id pca9570_of_match_table[] = {
{ .compatible = "nxp,pca9570", .data = (void *)4 },
+ { .compatible = "nxp,pca9571", .data = (void *)8 },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, pca9570_of_match_table);
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] gpio: pca9570: add pca9571 support
2022-06-10 16:48 [PATCH] gpio: pca9570: add pca9571 support Lucas Stach
@ 2022-06-13 10:03 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2022-06-13 10:03 UTC (permalink / raw)
To: Lucas Stach
Cc: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Sungbo Eo,
open list:GPIO SUBSYSTEM, devicetree, Sascha Hauer, patchwork-lst
On Fri, Jun 10, 2022 at 6:48 PM Lucas Stach <l.stach@pengutronix.de> wrote:
>
> The PCA9571 very similar to the PCA9570, it only differs in the
> number of GPIOs.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml | 1 +
> drivers/gpio/gpio-pca9570.c | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
> index 338c5312a106..1acaa0a3d35a 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
> @@ -13,6 +13,7 @@ properties:
> compatible:
> enum:
> - nxp,pca9570
> + - nxp,pca9571
>
> reg:
> maxItems: 1
> diff --git a/drivers/gpio/gpio-pca9570.c b/drivers/gpio/gpio-pca9570.c
> index cb2b2f735c15..ab2a652964ec 100644
> --- a/drivers/gpio/gpio-pca9570.c
> +++ b/drivers/gpio/gpio-pca9570.c
> @@ -121,12 +121,14 @@ static int pca9570_probe(struct i2c_client *client)
>
> static const struct i2c_device_id pca9570_id_table[] = {
> { "pca9570", 4 },
> + { "pca9571", 8 },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(i2c, pca9570_id_table);
>
> static const struct of_device_id pca9570_of_match_table[] = {
> { .compatible = "nxp,pca9570", .data = (void *)4 },
> + { .compatible = "nxp,pca9571", .data = (void *)8 },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, pca9570_of_match_table);
> --
> 2.30.2
>
Looks good, just please split it into two separate patches, one for DT
bindings and one for the driver.
Thanks,
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-13 10:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-10 16:48 [PATCH] gpio: pca9570: add pca9571 support Lucas Stach
2022-06-13 10:03 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).