From: Colin Foster <colin.foster@in-advantage.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Linus Walleij <linus.walleij@linaro.org>,
Wolfram Sang <wsa@kernel.org>,
Terry Bowman <terry.bowman@amd.com>,
katie.morris@in-advantage.com
Subject: Re: [PATCH v12 net-next 2/9] net: mdio: mscc-miim: add ability to be used in a non-mmio configuration
Date: Fri, 1 Jul 2022 13:38:30 -0700 [thread overview]
Message-ID: <20220701203830.GC3327062@euler> (raw)
In-Reply-To: <CAHp75VdZwUj7dGQsiWR=M_UgxFz0q669bsdsKq3xAD3Wqv+2dw@mail.gmail.com>
On Fri, Jul 01, 2022 at 10:24:46PM +0200, Andy Shevchenko wrote:
> On Fri, Jul 1, 2022 at 9:26 PM Colin Foster
> <colin.foster@in-advantage.com> wrote:
> >
> > There are a few Ocelot chips that contain the logic for this bus, but are
> > controlled externally. Specifically the VSC7511, 7512, 7513, and 7514. In
> > the externally controlled configurations these registers are not
> > memory-mapped.
> >
> > Add support for these non-memory-mapped configurations.
>
> ...
>
> > + phy_regmap = ocelot_regmap_from_resource_optional(pdev, 1,
> > + &mscc_miim_phy_regmap_config);
> > + if (IS_ERR(phy_regmap)) {
> > + dev_err(dev, "Unable to create phy register regmap\n");
> > + return PTR_ERR(phy_regmap);
>
> return dev_err_probe(...); ?
Thanks. Also the same is in pinctrl-ocelot. Fixing in my tree right now.
>
> > }
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2022-07-01 20:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 19:26 [PATCH v12 net-next 0/9] add support for VSC7512 control over SPI Colin Foster
2022-07-01 19:26 ` [PATCH v12 net-next 1/9] mfd: ocelot: add helper to get regmap from a resource Colin Foster
2022-07-01 20:23 ` Andy Shevchenko
2022-07-01 20:34 ` Colin Foster
2022-07-01 20:41 ` Andy Shevchenko
2022-07-01 19:26 ` [PATCH v12 net-next 2/9] net: mdio: mscc-miim: add ability to be used in a non-mmio configuration Colin Foster
2022-07-01 20:24 ` Andy Shevchenko
2022-07-01 20:38 ` Colin Foster [this message]
2022-07-01 19:26 ` [PATCH v12 net-next 3/9] pinctrl: ocelot: allow pinctrl-ocelot to be loaded as a module Colin Foster
2022-07-01 19:26 ` [PATCH v12 net-next 4/9] pinctrl: ocelot: add ability to be used in a non-mmio configuration Colin Foster
2022-07-01 19:26 ` [PATCH v12 net-next 5/9] pinctrl: microchip-sgpio: allow sgpio driver to be used as a module Colin Foster
2022-07-01 19:26 ` [PATCH v12 net-next 6/9] pinctrl: microchip-sgpio: add ability to be used in a non-mmio configuration Colin Foster
2022-07-01 19:26 ` [PATCH v12 net-next 7/9] resource: add define macro for register address resources Colin Foster
2022-07-01 19:26 ` [PATCH v12 net-next 8/9] dt-bindings: mfd: ocelot: add bindings for VSC7512 Colin Foster
2022-07-05 20:26 ` Rob Herring
2022-07-01 19:26 ` [PATCH v12 net-next 9/9] mfd: ocelot: add support for the vsc7512 chip via spi Colin Foster
2022-07-01 20:38 ` Andy Shevchenko
2022-07-01 21:04 ` Colin Foster
2022-07-02 3:02 ` Jakub Kicinski
2022-07-02 16:26 ` Colin Foster
2022-07-02 10:04 ` kernel test robot
2022-07-05 20:24 ` [PATCH v12 net-next 0/9] add support for VSC7512 control over SPI Rob Herring
2022-07-05 20:30 ` Colin Foster
2022-07-05 22:04 ` Vladimir Oltean
2022-07-05 22:56 ` Vladimir Oltean
2022-07-06 4:34 ` Colin Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701203830.GC3327062@euler \
--to=colin.foster@in-advantage.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=katie.morris@in-advantage.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=terry.bowman@amd.com \
--cc=vladimir.oltean@nxp.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).