* [PATCH v12 2/7] dt-bindings: pinctrl: sunxi: Make interrupts optional [not found] <20220701112453.2310722-1-andre.przywara@arm.com> @ 2022-07-01 11:24 ` Andre Przywara 2022-07-01 20:57 ` Rob Herring 2022-07-04 23:55 ` Samuel Holland 2022-07-01 11:24 ` [PATCH v12 4/7] dt-bindings: pinctrl: sunxi: allow vcc-pi-supply Andre Przywara 1 sibling, 2 replies; 6+ messages in thread From: Andre Przywara @ 2022-07-01 11:24 UTC (permalink / raw) To: Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Rob Herring, Krzysztof Kozlowski Cc: Linus Walleij, devicetree, linux-arm-kernel, linux-sunxi, linux-kernel, linux-gpio The R_PIO pinctrl device on the Allwinner H616 SoC does not have an interrupt (it features only two pins). However the binding requires at least naming one upstream interrupt, plus the #interrupt-cells and interrupt-controller properties. Drop the unconditional requirement for the interrupt properties, and make them dependent on being not this particular pinctrl device. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- .../pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml index bfce850c20351..0bd903954195b 100644 --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml @@ -133,14 +133,11 @@ patternProperties: required: - "#gpio-cells" - - "#interrupt-cells" - compatible - reg - - interrupts - clocks - clock-names - gpio-controller - - interrupt-controller allOf: # FIXME: We should have the pin bank supplies here, but not a lot of @@ -148,6 +145,18 @@ allOf: # warnings. - $ref: "pinctrl.yaml#" + - if: + not: + properties: + compatible: + enum: + - allwinner,sun50i-h616-r-pinctrl + then: + required: + - "#interrupt-cells" + - interrupts + - interrupt-controller + - if: properties: compatible: -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v12 2/7] dt-bindings: pinctrl: sunxi: Make interrupts optional 2022-07-01 11:24 ` [PATCH v12 2/7] dt-bindings: pinctrl: sunxi: Make interrupts optional Andre Przywara @ 2022-07-01 20:57 ` Rob Herring 2022-07-04 23:55 ` Samuel Holland 1 sibling, 0 replies; 6+ messages in thread From: Rob Herring @ 2022-07-01 20:57 UTC (permalink / raw) To: Andre Przywara Cc: Chen-Yu Tsai, Rob Herring, linux-arm-kernel, Jernej Skrabec, Samuel Holland, Linus Walleij, Krzysztof Kozlowski, linux-kernel, linux-gpio, devicetree, linux-sunxi On Fri, 01 Jul 2022 12:24:48 +0100, Andre Przywara wrote: > The R_PIO pinctrl device on the Allwinner H616 SoC does not have an > interrupt (it features only two pins). > However the binding requires at least naming one upstream interrupt, > plus the #interrupt-cells and interrupt-controller properties. > > Drop the unconditional requirement for the interrupt properties, and > make them dependent on being not this particular pinctrl device. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > .../pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v12 2/7] dt-bindings: pinctrl: sunxi: Make interrupts optional 2022-07-01 11:24 ` [PATCH v12 2/7] dt-bindings: pinctrl: sunxi: Make interrupts optional Andre Przywara 2022-07-01 20:57 ` Rob Herring @ 2022-07-04 23:55 ` Samuel Holland 1 sibling, 0 replies; 6+ messages in thread From: Samuel Holland @ 2022-07-04 23:55 UTC (permalink / raw) To: Andre Przywara, Chen-Yu Tsai, Jernej Skrabec Cc: Rob Herring, Krzysztof Kozlowski, Linus Walleij, devicetree, linux-arm-kernel, linux-sunxi, linux-kernel, linux-gpio On 7/1/22 6:24 AM, Andre Przywara wrote: > The R_PIO pinctrl device on the Allwinner H616 SoC does not have an > interrupt (it features only two pins). > However the binding requires at least naming one upstream interrupt, > plus the #interrupt-cells and interrupt-controller properties. > > Drop the unconditional requirement for the interrupt properties, and > make them dependent on being not this particular pinctrl device. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Acked-by: Samuel Holland <samuel@sholland.org> > --- > .../pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > index bfce850c20351..0bd903954195b 100644 > --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > @@ -133,14 +133,11 @@ patternProperties: > > required: > - "#gpio-cells" > - - "#interrupt-cells" > - compatible > - reg > - - interrupts > - clocks > - clock-names > - gpio-controller > - - interrupt-controller > > allOf: > # FIXME: We should have the pin bank supplies here, but not a lot of > @@ -148,6 +145,18 @@ allOf: > # warnings. > > - $ref: "pinctrl.yaml#" > + - if: > + not: > + properties: > + compatible: > + enum: > + - allwinner,sun50i-h616-r-pinctrl > + then: Nit: all of the existing ifs and thens have blank lines between them. > + required: > + - "#interrupt-cells" > + - interrupts > + - interrupt-controller > + > - if: > properties: > compatible: > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v12 4/7] dt-bindings: pinctrl: sunxi: allow vcc-pi-supply [not found] <20220701112453.2310722-1-andre.przywara@arm.com> 2022-07-01 11:24 ` [PATCH v12 2/7] dt-bindings: pinctrl: sunxi: Make interrupts optional Andre Przywara @ 2022-07-01 11:24 ` Andre Przywara 2022-07-01 20:57 ` Rob Herring 2022-07-05 1:18 ` Samuel Holland 1 sibling, 2 replies; 6+ messages in thread From: Andre Przywara @ 2022-07-01 11:24 UTC (permalink / raw) To: Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Rob Herring, Krzysztof Kozlowski Cc: Linus Walleij, devicetree, linux-arm-kernel, linux-sunxi, linux-kernel, linux-gpio The Allwinner H616 SoC contains a VCC_PI pin, which supplies the voltage for GPIO port I. Extend the range of supply port names to include vcc-pi-supply to cover that. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- .../bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml index 0bd903954195b..25d31c8a191a8 100644 --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml @@ -127,7 +127,7 @@ patternProperties: additionalProperties: false - "^vcc-p[a-hlm]-supply$": + "^vcc-p[a-ilm]-supply$": description: Power supplies for pin banks. -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v12 4/7] dt-bindings: pinctrl: sunxi: allow vcc-pi-supply 2022-07-01 11:24 ` [PATCH v12 4/7] dt-bindings: pinctrl: sunxi: allow vcc-pi-supply Andre Przywara @ 2022-07-01 20:57 ` Rob Herring 2022-07-05 1:18 ` Samuel Holland 1 sibling, 0 replies; 6+ messages in thread From: Rob Herring @ 2022-07-01 20:57 UTC (permalink / raw) To: Andre Przywara Cc: Chen-Yu Tsai, Linus Walleij, linux-kernel, devicetree, linux-arm-kernel, Samuel Holland, Krzysztof Kozlowski, linux-sunxi, Jernej Skrabec, linux-gpio, Rob Herring On Fri, 01 Jul 2022 12:24:50 +0100, Andre Przywara wrote: > The Allwinner H616 SoC contains a VCC_PI pin, which supplies the voltage > for GPIO port I. > Extend the range of supply port names to include vcc-pi-supply to cover > that. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > .../bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v12 4/7] dt-bindings: pinctrl: sunxi: allow vcc-pi-supply 2022-07-01 11:24 ` [PATCH v12 4/7] dt-bindings: pinctrl: sunxi: allow vcc-pi-supply Andre Przywara 2022-07-01 20:57 ` Rob Herring @ 2022-07-05 1:18 ` Samuel Holland 1 sibling, 0 replies; 6+ messages in thread From: Samuel Holland @ 2022-07-05 1:18 UTC (permalink / raw) To: Andre Przywara Cc: Chen-Yu Tsai, Jernej Skrabec, Rob Herring, Krzysztof Kozlowski, Linus Walleij, devicetree, linux-arm-kernel, linux-sunxi, linux-kernel, linux-gpio On 7/1/22 6:24 AM, Andre Przywara wrote: > The Allwinner H616 SoC contains a VCC_PI pin, which supplies the voltage > for GPIO port I. > Extend the range of supply port names to include vcc-pi-supply to cover > that. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Acked-by: Samuel Holland <samuel@sholland.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-05 1:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220701112453.2310722-1-andre.przywara@arm.com>
2022-07-01 11:24 ` [PATCH v12 2/7] dt-bindings: pinctrl: sunxi: Make interrupts optional Andre Przywara
2022-07-01 20:57 ` Rob Herring
2022-07-04 23:55 ` Samuel Holland
2022-07-01 11:24 ` [PATCH v12 4/7] dt-bindings: pinctrl: sunxi: allow vcc-pi-supply Andre Przywara
2022-07-01 20:57 ` Rob Herring
2022-07-05 1:18 ` Samuel Holland
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).