From: Michael Walle <michael@walle.cc>
To: horatiu.vultur@microchip.com
Cc: UNGLinuxDriver@microchip.com, alexandre.belloni@bootlin.com,
colin.foster@in-advantage.com, kavyasree.kotagiri@microchip.com,
linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, maxime.chevallier@bootlin.com,
Michael Walle <michael@walle.cc>
Subject: Re: [PATCH 1/2] pinctrl: ocelot: Fix pincfg for lan966x
Date: Fri, 8 Jul 2022 10:27:52 +0200 [thread overview]
Message-ID: <20220708082752.1745233-1-michael@walle.cc> (raw)
In-Reply-To: <20220707185342.2697569-2-horatiu.vultur@microchip.com>
> -static struct pinctrl_desc luton_desc = {
> - .name = "luton-pinctrl",
> - .pins = luton_pins,
> - .npins = ARRAY_SIZE(luton_pins),
> - .pctlops = &ocelot_pctl_ops,
> - .pmxops = &ocelot_pmx_ops,
> - .owner = THIS_MODULE,
> +static struct ocelot_match_data luton_desc = {
> + {
.desc = {
Same for all the structs. Also it looks like it is way too big
for a stable backport:
"It cannot be bigger than 100 lines, with context."
> + .name = "luton-pinctrl",
> + .pins = luton_pins,
> + .npins = ARRAY_SIZE(luton_pins),
> + .pctlops = &ocelot_pctl_ops,
> + .pmxops = &ocelot_pmx_ops,
> + .owner = THIS_MODULE,
> + }
> };
-michael
next prev parent reply other threads:[~2022-07-08 8:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 18:53 [PATCH 0/2] pinctrl: ocelot: Add fixes for ocelot driver Horatiu Vultur
2022-07-07 18:53 ` [PATCH 1/2] pinctrl: ocelot: Fix pincfg for lan966x Horatiu Vultur
2022-07-08 8:27 ` Michael Walle [this message]
2022-07-08 19:45 ` Horatiu Vultur
2022-07-07 18:53 ` [PATCH 2/2] pinctrl: ocelot: Fix pincfg Horatiu Vultur
2022-07-08 0:31 ` Colin Foster
2022-07-08 19:41 ` Horatiu Vultur
2022-07-08 2:05 ` kernel test robot
2022-07-08 6:21 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220708082752.1745233-1-michael@walle.cc \
--to=michael@walle.cc \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=colin.foster@in-advantage.com \
--cc=horatiu.vultur@microchip.com \
--cc=kavyasree.kotagiri@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).