From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
<kavyasree.kotagiri@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
Colin Foster <colin.foster@in-advantage.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Michael Walle <michael@walle.cc>
Subject: Re: [PATCH v3 2/2] pinctrl: ocelot: Fix pincfg
Date: Mon, 11 Jul 2022 22:26:46 +0200 [thread overview]
Message-ID: <20220711202646.om65vrksyifvkfkw@soft-dev3-1.localhost> (raw)
In-Reply-To: <CAHp75VdeZSP62qoOdQf=g4b7AheFd4=jNxfjMh-_T7Q1Zi=LbA@mail.gmail.com>
The 07/11/2022 21:51, Andy Shevchenko wrote:
>
> On Mon, Jul 11, 2022 at 9:17 PM Horatiu Vultur
> <horatiu.vultur@microchip.com> wrote:
> >
> > The blamed commit changed to use regmaps instead of __iomem. But it
> > didn't update the register offsets to be at word offset, so it uses byte
> > offset.
> > Another issue with the same commit is that it has a limit of 32 registers
> > which is incorrect. The sparx5 has 64 while lan966x has 77.
>
> ...
>
> > -static struct regmap *ocelot_pinctrl_create_pincfg(struct platform_device *pdev)
> > +static struct regmap *ocelot_pinctrl_create_pincfg(struct ocelot_pinctrl *info,
> > + struct platform_device *pdev)
>
> const?
>
> And I would leave pdev to be the first parameter, if there are no
> other functions that have them like this.
I will do that in the next version.
Just for my understanding/knowledge why is this desire to have const or
to keep the const?
>
> --
> With Best Regards,
> Andy Shevchenko
--
/Horatiu
next prev parent reply other threads:[~2022-07-11 20:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 19:21 [PATCH v3 0/2] pinctrl: ocelot: Add fixes for ocelot driver Horatiu Vultur
2022-07-11 19:21 ` [PATCH v3 1/2] pinctrl: ocelot: Fix pincfg for lan966x Horatiu Vultur
2022-07-11 19:47 ` Andy Shevchenko
2022-07-11 20:21 ` Horatiu Vultur
2022-07-12 3:53 ` Colin Foster
2022-07-11 19:21 ` [PATCH v3 2/2] pinctrl: ocelot: Fix pincfg Horatiu Vultur
2022-07-11 19:51 ` Andy Shevchenko
2022-07-11 20:26 ` Horatiu Vultur [this message]
2022-07-11 20:29 ` Andy Shevchenko
2022-07-11 20:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220711202646.om65vrksyifvkfkw@soft-dev3-1.localhost \
--to=horatiu.vultur@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andy.shevchenko@gmail.com \
--cc=colin.foster@in-advantage.com \
--cc=kavyasree.kotagiri@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=michael@walle.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).