From: kernel test robot <lkp@intel.com>
To: "Nuno Sá" <nuno.sa@analog.com>,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-input@vger.kernel.org
Cc: kbuild-all@lists.01.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Michael Hennerich <michael.hennerich@analog.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 01/10] input: keyboard: adp5588-keys: support gpi key events as 'gpio keys'
Date: Tue, 12 Jul 2022 13:29:24 +0800 [thread overview]
Message-ID: <202207121357.JpS5DGdP-lkp@intel.com> (raw)
In-Reply-To: <20220708093448.42617-2-nuno.sa@analog.com>
Hi "Nuno,
I love your patch! Perhaps something to improve:
[auto build test WARNING on dtor-input/next]
[also build test WARNING on next-20220711]
[cannot apply to brgl/gpio/for-next hid/for-next linus/master v5.19-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Nuno-S/adp5588-keys-refactor-and-fw-properties-support/20220708-173730
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220712/202207121357.JpS5DGdP-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
smatch warnings:
drivers/input/keyboard/adp5588-keys.c:342 adp5588_gpio_irq_handle() warn: unsigned 'hwirq' is never less than zero.
vim +/hwirq +342 drivers/input/keyboard/adp5588-keys.c
333
334 static void adp5588_gpio_irq_handle(struct adp5588_kpad *kpad, int key_val,
335 int key_press)
336 {
337 unsigned int irq, gpio = key_val - GPI_PIN_BASE, irq_type, hwirq;
338 struct i2c_client *client = kpad->client;
339 struct irq_data *desc;
340
341 hwirq = adp5588_gpiomap_get_hwirq(kpad->gpiomap, gpio, kpad->gc.ngpio);
> 342 if (hwirq < 0) {
343 dev_err(&client->dev, "Could not get hwirq for key(%u)\n", key_val);
344 return;
345 }
346
347 irq = irq_find_mapping(kpad->gc.irq.domain, hwirq);
348 if (irq <= 0)
349 return;
350
351 desc = irq_get_irq_data(irq);
352 if (!desc) {
353 dev_err(&client->dev, "Could not get irq(%u) data\n", irq);
354 return;
355 }
356
357 irq_type = irqd_get_trigger_type(desc);
358
359 /*
360 * Default is active low which means key_press is asserted on
361 * the falling edge.
362 */
363 if ((irq_type & IRQ_TYPE_EDGE_RISING && !key_press) ||
364 (irq_type & IRQ_TYPE_EDGE_FALLING && key_press))
365 handle_nested_irq(irq);
366 }
367
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-07-12 5:30 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 9:34 [PATCH 00/10] adp5588-keys refactor and fw properties support Nuno Sá
2022-07-08 9:34 ` [PATCH 01/10] input: keyboard: adp5588-keys: support gpi key events as 'gpio keys' Nuno Sá
2022-07-08 14:18 ` Andy Shevchenko
2022-07-08 14:55 ` Sa, Nuno
2022-07-08 15:04 ` Andy Shevchenko
2022-07-08 15:24 ` Sa, Nuno
2022-07-11 14:16 ` Nuno Sá
2022-07-09 4:10 ` kernel test robot
2022-07-09 11:52 ` Andy Shevchenko
2022-07-12 5:29 ` kernel test robot [this message]
2022-07-08 9:34 ` [PATCH 02/10] gpio: gpio-adp5588: drop the driver Nuno Sá
2022-07-08 13:28 ` Bartosz Golaszewski
2022-07-08 9:34 ` [PATCH 03/10] input: keyboard: adp5588-keys: bail out on returned error Nuno Sá
2022-07-08 14:25 ` Andy Shevchenko
2022-07-08 14:35 ` Sa, Nuno
2022-07-08 14:57 ` Andy Shevchenko
2022-07-08 9:34 ` [PATCH 04/10] input: keyboard: adp5588-keys: add support for fw properties Nuno Sá
2022-07-08 14:56 ` Andy Shevchenko
2022-07-08 15:04 ` Sa, Nuno
2022-07-08 15:07 ` Andy Shevchenko
2022-07-12 14:31 ` Nuno Sá
2022-07-09 1:14 ` kernel test robot
2022-07-08 9:34 ` [PATCH 05/10] dt-bindings: input: adp5588-keys: add bindings Nuno Sá
2022-07-11 23:03 ` Rob Herring
2022-07-08 9:34 ` [PATCH 06/10] input: keyboard: adp5588-keys: do not check for irq presence Nuno Sá
2022-07-08 9:34 ` [PATCH 07/10] input: keyboard: adp5588-keys: fix coding style warnings Nuno Sá
2022-07-08 14:49 ` Andy Shevchenko
2022-07-08 15:05 ` Sa, Nuno
2022-07-08 15:10 ` Andy Shevchenko
2022-07-08 9:34 ` [PATCH 08/10] input: keyboard: adp5588-keys: add optional reset gpio Nuno Sá
2022-07-11 12:52 ` Linus Walleij
2022-07-08 9:34 ` [PATCH 09/10] input: keyboard: adp5588-keys: add regulator support Nuno Sá
2022-07-08 14:47 ` Andy Shevchenko
2022-07-08 15:00 ` Sa, Nuno
2022-07-08 9:34 ` [PATCH 10/10] input: keyboard: adp5588-keys: Use new PM macros Nuno Sá
2022-07-08 13:59 ` [PATCH 00/10] adp5588-keys refactor and fw properties support Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202207121357.JpS5DGdP-lkp@intel.com \
--to=lkp@intel.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).