From: Kent Gibson <warthog618@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
brgl@bgdev.pl, dipenp@nvidia.com, andy.shevchenko@gmail.com
Subject: Re: [PATCH v2 5/6] gpiolib: cdev: consolidate edge detector configuration flags
Date: Mon, 18 Jul 2022 17:46:20 +0800 [thread overview]
Message-ID: <20220718094620.GA96704@sol> (raw)
In-Reply-To: <CACRpkdZ5O7iNOaJgq5D8hpQDO207DsQkqjRu_m1aZSPy5_qoJA@mail.gmail.com>
On Mon, Jul 18, 2022 at 11:33:48AM +0200, Linus Walleij wrote:
> On Thu, Jul 14, 2022 at 4:04 AM Kent Gibson <warthog618@gmail.com> wrote:
>
> > Combine the polarity_change flag, struct line eflags, and hte enable
> > flag into a single flag variable.
> >
> > The combination of these flags describes the configuration state
> > of the edge detector, so formalize and clarify that by combining
> > them into a single variable, edflags, in struct line.
> >
> > The edflags is a subset of the GPIO_V2_LINE_FLAGsb relevant to
>
> What is that "b" at the end of GPIO_V2_LINE_FLAGsb?
> Oh well no big deal. Bart can fix when applying if it is disturbing.
>
Yeah, typo or something - no idea what that is doing there, but it has
been there since v1. ¯\_(ツ)_/¯
Bart - please do fix that if you don't mind.
Thanks for the review.
Cheers,
Kent.
next prev parent reply other threads:[~2022-07-18 9:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 2:03 [PATCH v2 0/6] gpiolib: cdev: code cleanup following hte integration Kent Gibson
2022-07-14 2:03 ` [PATCH v2 1/6] gpiolib: cdev: simplify linereq_free Kent Gibson
2022-07-15 5:09 ` Dipen Patel
2022-07-18 9:28 ` Linus Walleij
2022-07-14 2:03 ` [PATCH v2 2/6] gpiolib: cdev: simplify parameter in call to hte_edge_setup Kent Gibson
2022-07-15 5:10 ` Dipen Patel
2022-07-18 9:29 ` Linus Walleij
2022-07-14 2:03 ` [PATCH v2 3/6] gpiolib: cdev: replace if-else chains with switches Kent Gibson
2022-07-18 9:30 ` Linus Walleij
2022-07-14 2:03 ` [PATCH v2 4/6] gpiolib: cdev: simplify line event identification Kent Gibson
2022-07-18 9:31 ` Linus Walleij
2022-07-14 2:03 ` [PATCH v2 5/6] gpiolib: cdev: consolidate edge detector configuration flags Kent Gibson
2022-07-18 9:33 ` Linus Walleij
2022-07-18 9:46 ` Kent Gibson [this message]
2022-07-14 2:03 ` [PATCH v2 6/6] gpiolib: cdev: compile out HTE unless CONFIG_HTE selected Kent Gibson
2022-07-18 9:34 ` Linus Walleij
2022-07-18 21:32 ` [PATCH v2 0/6] gpiolib: cdev: code cleanup following hte integration Dipen Patel
2022-07-19 8:03 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718094620.GA96704@sol \
--to=warthog618@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=dipenp@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).