From: "Nuno Sá" <nuno.sa@analog.com>
To: <linux-input@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<devicetree@vger.kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Hennerich <michael.hennerich@analog.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: [PATCH v3 08/10] input: keyboard: adp5588-keys: add optional reset gpio
Date: Thu, 21 Jul 2022 10:04:21 +0200 [thread overview]
Message-ID: <20220721080423.156151-9-nuno.sa@analog.com> (raw)
In-Reply-To: <20220721080423.156151-1-nuno.sa@analog.com>
Optionally reset the device during probe.
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
drivers/input/keyboard/adp5588-keys.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/input/keyboard/adp5588-keys.c b/drivers/input/keyboard/adp5588-keys.c
index 1c4b1ea724b0..908b6865a2e6 100644
--- a/drivers/input/keyboard/adp5588-keys.c
+++ b/drivers/input/keyboard/adp5588-keys.c
@@ -11,6 +11,7 @@
#include <linux/bits.h>
#include <linux/delay.h>
#include <linux/errno.h>
+#include <linux/gpio/consumer.h>
#include <linux/gpio/driver.h>
#include <linux/i2c.h>
#include <linux/input.h>
@@ -710,6 +711,7 @@ static int adp5588_probe(struct i2c_client *client,
{
struct adp5588_kpad *kpad;
struct input_dev *input;
+ struct gpio_desc *gpio;
unsigned int revid;
int ret;
int error;
@@ -735,6 +737,16 @@ static int adp5588_probe(struct i2c_client *client,
if (error)
return error;
+ gpio = devm_gpiod_get_optional(&client->dev, "reset", GPIOD_OUT_HIGH);
+ if (IS_ERR(gpio))
+ return PTR_ERR(gpio);
+
+ if (gpio) {
+ fsleep(30);
+ gpiod_set_value_cansleep(gpio, 0);
+ fsleep(60);
+ }
+
ret = adp5588_read(client, DEV_ID);
if (ret < 0)
return ret;
--
2.37.1
next prev parent reply other threads:[~2022-07-21 8:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 8:04 [PATCH v3 00/10] adp5588-keys refactor and fw properties support Nuno Sá
2022-07-21 8:04 ` [PATCH v3 01/10] input: keyboard: adp5588-keys: support gpi key events as 'gpio keys' Nuno Sá
2022-07-23 4:56 ` kernel test robot
2022-07-25 20:31 ` Andy Shevchenko
2022-08-29 11:21 ` Sa, Nuno
2022-07-25 20:34 ` Andy Shevchenko
2022-08-29 11:20 ` Sa, Nuno
2022-07-26 10:30 ` kernel test robot
2022-08-31 12:24 ` Linus Walleij
2022-08-31 12:26 ` Andy Shevchenko
2022-08-31 12:28 ` Sa, Nuno
2022-08-31 12:30 ` Linus Walleij
2022-07-21 8:04 ` [PATCH v3 02/10] gpio: gpio-adp5588: drop the driver Nuno Sá
2022-07-21 8:04 ` [PATCH v3 03/10] input: keyboard: adp5588-keys: bail out on returned error Nuno Sá
2022-07-21 8:04 ` [PATCH v3 04/10] input: keyboard: adp5588-keys: add support for fw properties Nuno Sá
2022-07-21 8:04 ` [PATCH v3 05/10] dt-bindings: input: adp5588: add bindings Nuno Sá
2022-07-21 8:33 ` Krzysztof Kozlowski
2022-07-21 8:04 ` [PATCH v3 06/10] input: keyboard: adp5588-keys: do not check for irq presence Nuno Sá
2022-07-21 8:04 ` [PATCH v3 07/10] input: keyboard: adp5588-keys: fix coding style warnings Nuno Sá
2022-07-21 8:04 ` Nuno Sá [this message]
2022-07-21 8:04 ` [PATCH v3 09/10] input: keyboard: adp5588-keys: add regulator support Nuno Sá
2022-07-21 8:04 ` [PATCH v3 10/10] input: keyboard: adp5588-keys: Use new PM macros Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220721080423.156151-9-nuno.sa@analog.com \
--to=nuno.sa@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).