* [PATCH] gpio: mxc: Always set GPIOs used as interrupt source to INPUT mode
@ 2022-07-23 20:11 Marek Vasut
0 siblings, 0 replies; only message in thread
From: Marek Vasut @ 2022-07-23 20:11 UTC (permalink / raw)
To: linux-gpio
Cc: Marek Vasut, Bartosz Golaszewski, Linus Walleij, Loic Poulain,
Marc Zyngier
Always configure GPIO pins which are used as interrupt source as INPUTs.
In case the default pin configuration is OUTPUT, or the prior stage does
configure the pins as OUTPUT, then Linux will not reconfigure the pin as
INPUT and no interrupts are received.
Always configure interrupt source GPIO pin as input to fix the above case.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Loic Poulain <loic.poulain@linaro.org>
Cc: Marc Zyngier <maz@kernel.org>
---
drivers/gpio/gpio-mxc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
index c871602fc5ba9..d4e8146e38d57 100644
--- a/drivers/gpio/gpio-mxc.c
+++ b/drivers/gpio/gpio-mxc.c
@@ -204,6 +204,8 @@ static int gpio_set_irq_type(struct irq_data *d, u32 type)
writel(1 << gpio_idx, port->base + GPIO_ISR);
+ writel(1 << gpio_idx, port->base + GPIO_GDIR);
+
return 0;
}
--
2.35.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-07-23 20:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-23 20:11 [PATCH] gpio: mxc: Always set GPIOs used as interrupt source to INPUT mode Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).