From: Conor Dooley <mail@conchuod.ie>
To: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Conor Dooley <conor.dooley@microchip.com>,
Atul Khare <atulkhare@rivosinc.com>,
Sagar Kadam <sagar.kadam@sifive.com>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 0/2] Fix SiFive dt-schema errors
Date: Tue, 26 Jul 2022 18:07:24 +0100 [thread overview]
Message-ID: <20220726170725.3245278-1-mail@conchuod.ie> (raw)
From: Conor Dooley <conor.dooley@microchip.com>
Hi all,
As these are the last remaining dtbs_check warnings for the default
riscv defconfig I am reviving the series. Atul has been hit by some
hardware issues so has not had a chance to send an applicable version
of these patches. All I have done here is rebase on linux-next, so by
the time the merge window reopens it will hopefully apply..
On Atul's V2, Rob had a comment about changing the cache-sets in the
patch 1/2:
There is not any way to express power of 2, so you have to list values.
Rather than just adding 1 more value, I would add at least a few more so
we're not adding these one by one. This is for a specific cache
implementation, so it can't really be *any* power of 2. Designs have
some limits or physics does. /endquote
I don't think that there's value in speculatively adding values to this
enum especially as (I think at least) the scala for this cache IP has
been released publicly:
https://github.com/sifive/block-inclusivecache-sifive/blob/master/design/craft/inclusivecache/src/Parameters.scala#L32
The two compatibles in the file match only against two specific cache
implemenations: the fu540's & the fu740's. I would seem to me that, it
would be better to lock this to a single value per compatible since the
1024 applies to the fu540 & the new value of 2048 applies only to the
fu740.
I have not made that change, I simply wanted to repackage this series
in a way that could be more easily applied & restart the discussion.
Thanks,
Conor.
Atul Khare (2):
dt-bindings: sifive: add cache-set value of 2048
dt-bindings: sifive: add gpio-line-names
Documentation/devicetree/bindings/gpio/sifive,gpio.yaml | 4 ++++
Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
base-commit: 058affafc65a74cf54499fb578b66ad0b18f939b
--
2.37.1
next reply other threads:[~2022-07-26 17:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 17:07 Conor Dooley [this message]
2022-07-26 17:07 ` [PATCH v3 1/2] dt-bindings: sifive: add cache-set value of 2048 Conor Dooley
2022-07-26 17:35 ` Krzysztof Kozlowski
2022-07-26 17:39 ` Conor.Dooley
2022-07-27 7:13 ` Krzysztof Kozlowski
2022-07-27 7:19 ` Conor.Dooley
2022-07-26 17:07 ` [PATCH v3 2/2] dt-bindings: sifive: add gpio-line-names Conor Dooley
2022-07-27 15:23 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220726170725.3245278-1-mail@conchuod.ie \
--to=mail@conchuod.ie \
--cc=aou@eecs.berkeley.edu \
--cc=atulkhare@rivosinc.com \
--cc=brgl@bgdev.pl \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sagar.kadam@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).