* [PATCH v2] gpio/rockchip: Convert to generic_handle_domain_irq()
@ 2022-08-24 1:06 Jeffy Chen
2022-08-31 12:11 ` Linus Walleij
2022-08-31 12:38 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Jeffy Chen @ 2022-08-24 1:06 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Jianqun Xu, Jeffy Chen, linux-rockchip, Linus Walleij,
Bartosz Golaszewski, linux-kernel, linux-gpio, linux-arm-kernel
Follow commit dbd1c54fc820 ("gpio: Bulk conversion to
generic_handle_domain_irq()").
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
Changes in v2:
Use for_each_set_bit().
drivers/gpio/gpio-rockchip.c | 21 +++++----------------
1 file changed, 5 insertions(+), 16 deletions(-)
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index e342a6dc4c6c..03b05a56a66f 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -324,26 +324,15 @@ static void rockchip_irq_demux(struct irq_desc *desc)
{
struct irq_chip *chip = irq_desc_get_chip(desc);
struct rockchip_pin_bank *bank = irq_desc_get_handler_data(desc);
- u32 pend;
+ unsigned long pending;
+ unsigned int irq;
dev_dbg(bank->dev, "got irq for bank %s\n", bank->name);
chained_irq_enter(chip, desc);
- pend = readl_relaxed(bank->reg_base + bank->gpio_regs->int_status);
-
- while (pend) {
- unsigned int irq, virq;
-
- irq = __ffs(pend);
- pend &= ~BIT(irq);
- virq = irq_find_mapping(bank->domain, irq);
-
- if (!virq) {
- dev_err(bank->dev, "unmapped irq %d\n", irq);
- continue;
- }
-
+ pending = readl_relaxed(bank->reg_base + bank->gpio_regs->int_status);
+ for_each_set_bit(irq, &pending, 32) {
dev_dbg(bank->dev, "handling irq %d\n", irq);
/*
@@ -377,7 +366,7 @@ static void rockchip_irq_demux(struct irq_desc *desc)
} while ((data & BIT(irq)) != (data_old & BIT(irq)));
}
- generic_handle_irq(virq);
+ generic_handle_domain_irq(bank->domain, irq);
}
chained_irq_exit(chip, desc);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] gpio/rockchip: Convert to generic_handle_domain_irq()
2022-08-24 1:06 [PATCH v2] gpio/rockchip: Convert to generic_handle_domain_irq() Jeffy Chen
@ 2022-08-31 12:11 ` Linus Walleij
2022-08-31 12:38 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2022-08-31 12:11 UTC (permalink / raw)
To: Jeffy Chen
Cc: Heiko Stuebner, Jianqun Xu, linux-rockchip, Bartosz Golaszewski,
linux-kernel, linux-gpio, linux-arm-kernel
On Wed, Aug 24, 2022 at 3:13 AM Jeffy Chen <jeffy.chen@rock-chips.com> wrote:
> Follow commit dbd1c54fc820 ("gpio: Bulk conversion to
> generic_handle_domain_irq()").
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> ---
>
> Changes in v2:
> Use for_each_set_bit().
Pretty straight-forward!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
I think we have a few drivers that could be simplified the same way...
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] gpio/rockchip: Convert to generic_handle_domain_irq()
2022-08-24 1:06 [PATCH v2] gpio/rockchip: Convert to generic_handle_domain_irq() Jeffy Chen
2022-08-31 12:11 ` Linus Walleij
@ 2022-08-31 12:38 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2022-08-31 12:38 UTC (permalink / raw)
To: Jeffy Chen
Cc: Heiko Stuebner, Jianqun Xu, open list:ARM/Rockchip SoC...,
Linus Walleij, Linux Kernel Mailing List,
open list:GPIO SUBSYSTEM, Linux ARM
On Wed, Aug 24, 2022 at 3:13 AM Jeffy Chen <jeffy.chen@rock-chips.com> wrote:
>
> Follow commit dbd1c54fc820 ("gpio: Bulk conversion to
> generic_handle_domain_irq()").
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> ---
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-31 12:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-24 1:06 [PATCH v2] gpio/rockchip: Convert to generic_handle_domain_irq() Jeffy Chen
2022-08-31 12:11 ` Linus Walleij
2022-08-31 12:38 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).