From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88D44ECAAD4 for ; Tue, 30 Aug 2022 08:44:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230382AbiH3Iox (ORCPT ); Tue, 30 Aug 2022 04:44:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229543AbiH3Iow (ORCPT ); Tue, 30 Aug 2022 04:44:52 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D34495FB8 for ; Tue, 30 Aug 2022 01:44:49 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id h11-20020a17090a470b00b001fbc5ba5224so11154214pjg.2 for ; Tue, 30 Aug 2022 01:44:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc; bh=JbzIXp14whwZiEWpePza0tJks7qqH7QXTLeRE8LUEwk=; b=Kaq+VCJSXSeBjOwz4uj10z70wAAkT0EHwpaSfz3KhVomZTfcoywdK0FcqjpLCyLdn/ JrAoy10e42ty2BQ8VoYEdBUwzcRXXOAPxf6w6A0nk9tBExYbPeir+ETDlY+NIXYQXQ8y N18bQMMvTCiarry9ljqF9Sbloi9mB5JjqgqyJxkaWCHDwJggrW5gpUm/3c5MU3Zadqb5 5c9h4LGhzZB3UHAUisb5ATkRh4Y/xG69nT8hJYfJZljGM9mKwqbYa8rb36QXleTNda9B oxWg8YDhKIt19xljiT63DUp4oahJwdMtuO2h/GElwMdDHFDHDqQlOEUXu+4QhJ4O0zTn 6Grw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=JbzIXp14whwZiEWpePza0tJks7qqH7QXTLeRE8LUEwk=; b=Mw+gZpPCmpuXZeC4fqDj3dgKLNsyfDbKFN+kp9PJeIagfa3at+2ZS6/QY/aDWIir7l IUMyx2WbMKNUgLTeHnnuj1WTosB0/KrWynSn+ykJTgVcl3AoIGPuclbiEXpfHxj2x9Z6 DD/onyVtw2epRs0lzmx/pnSfIsY+xC6FZMcasbCOs6dFEjK2DLi4AksXBYu9JG1ImNED rrf+4VaY6k8iCiWDp5qB8SDjxPj2oumn6e0RNrvvRdhIoirpgKrlyJV6jYfnMag5XyuI 8xBKoHQH7ThrQdeGlPNmnbKGir5mCsDaJCqtZ/pfSfp2el7wnHJ5M2IjIcb/TwLzKj69 i7nQ== X-Gm-Message-State: ACgBeo0vFXqOxZBbOPO6fKvsGvwfaGmTvKKzCz2c9JpVnqJSrKdYnzsW 7UnffTJFn9uw0vCxA2VhGd1J X-Google-Smtp-Source: AA6agR7OLrfi21l1qp1fuRodigI5L4GFAZFbEKo1JeImXZ+WTHuDDpQCPNW8b9WT1eQHB0qto6zzMA== X-Received: by 2002:a17:90b:1a88:b0:1fd:6a42:3eb9 with SMTP id ng8-20020a17090b1a8800b001fd6a423eb9mr20749411pjb.154.1661849089311; Tue, 30 Aug 2022 01:44:49 -0700 (PDT) Received: from thinkpad ([117.193.209.245]) by smtp.gmail.com with ESMTPSA id h17-20020a170902f7d100b00174a4bcefc7sm4918735plw.217.2022.08.30.01.44.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Aug 2022 01:44:48 -0700 (PDT) Date: Tue, 30 Aug 2022 14:14:41 +0530 From: Manivannan Sadhasivam To: Marc Zyngier Cc: linus.walleij@linaro.org, bjorn.andersson@linaro.org, robimarko@gmail.com, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, johan+linaro@kernel.org, steev@kali.org Subject: Re: [PATCH v2] pinctrl: qcom: spmi-gpio: Make IRQCHIP immutable Message-ID: <20220830084441.GB135982@thinkpad> References: <20220830081212.164709-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Aug 30, 2022 at 09:26:51AM +0100, Marc Zyngier wrote: > On 2022-08-30 09:12, Manivannan Sadhasivam wrote: > > The IRQCHIP implementation used inside the gpiochips are not supposed to > > lower case > > > be changed during runtime. So let's make the one inside the spmi-gpio > > gpiochip immutable. > > > > This fixes the below warning during boot: > > gpio gpiochip0: (c440000.spmi:pmic@0:gpio@c000): not an immutable > > chip, please consider fixing it! > > > > Separate callbacks need to be provided for irq_{mask/unmask} pointers > > since > > the callbacks are supposed to mask/unmask the corresponding parent IRQ > > in > > addition to changing the gpio_desc flags. > > This is all part of the existing documentation, so I don't think > this is really needed. > Yes it is documented, but developers usually refer the commits doing the similar thing while doing these kind of conversions. For them, this text serves as a quick documentation. So I prefer to keep it in the commit message. Thanks, Mani > > > > Signed-off-by: Manivannan Sadhasivam > > With the above fixed: > > Acked-by: Marc Zyngier > > M. > -- > Jazz is not dead. It just smells funny... -- மணிவண்ணன் சதாசிவம்