From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45472ECAAA1 for ; Tue, 30 Aug 2022 22:50:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229923AbiH3Wun (ORCPT ); Tue, 30 Aug 2022 18:50:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230162AbiH3Wul (ORCPT ); Tue, 30 Aug 2022 18:50:41 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1F224CA3B; Tue, 30 Aug 2022 15:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661899839; x=1693435839; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lkEb1S9O0cY1S5Nc3U5QQ2ryw9NN9aiDiTt1Riy+deM=; b=L1JpZZn6NgHdyA3yOldaHnKFfFKHkJ6+rOBzIqCtm69InLSJCczgfP80 ibwOtLrrx4LtSIba3PbfJvvBfWdtN0ibEFu4UF48RSKPSVpDWw129ULf3 Y13WS/BG1rBsYqQJBWdyC4yA1XELdirVQB23NKY5TSxhXomczpJStYgQM 79KaZBU4G0A18PwxzCr1W1yn3QxlEkljER2xk8v5wELvizg26Mgqqsa8m N4ZVZomix9SLkooAErEuF2DW+6vMvlQDxLAFiNlvgWnNAgH+O5nLpMCM9 I/GqHCfEi7FcRRnBcskf28G6mW9hXZWf28pdDqG2ay6xPrAOI3023TGE3 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10455"; a="282297177" X-IronPort-AV: E=Sophos;i="5.93,276,1654585200"; d="scan'208";a="282297177" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 15:50:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,276,1654585200"; d="scan'208";a="645024235" Received: from lkp-server02.sh.intel.com (HELO 77b6d4e16fc5) ([10.239.97.151]) by orsmga001.jf.intel.com with ESMTP; 30 Aug 2022 15:50:35 -0700 Received: from kbuild by 77b6d4e16fc5 with local (Exim 4.96) (envelope-from ) id 1oTA43-0000hi-0r; Tue, 30 Aug 2022 22:50:35 +0000 Date: Wed, 31 Aug 2022 06:50:04 +0800 From: kernel test robot To: Andy Shevchenko , Linus Walleij , Jianqun Xu , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Bartosz Golaszewski , Heiko Stuebner , Andy Shevchenko Subject: Re: [PATCH v1 1/1] gpio: rockchip: Switch to use fwnode instead of of_node Message-ID: <202208310629.1JjkyeRu-lkp@intel.com> References: <20220830191939.56436-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220830191939.56436-1-andriy.shevchenko@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on rockchip/for-next] [also build test ERROR on linus/master v6.0-rc3 next-20220830] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/gpio-rockchip-Switch-to-use-fwnode-instead-of-of_node/20220831-032131 base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next config: hexagon-randconfig-r032-20220830 (https://download.01.org/0day-ci/archive/20220831/202208310629.1JjkyeRu-lkp@intel.com/config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project c7df82e4693c19e3fd2e25c83eb04d9deb7b7b59) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/678cf6450de6a016c041c3cd2ce58d1383d070e6 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Andy-Shevchenko/gpio-rockchip-Switch-to-use-fwnode-instead-of-of_node/20220831-032131 git checkout 678cf6450de6a016c041c3cd2ce58d1383d070e6 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/gpio/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/gpio/gpio-rockchip.c:614:8: error: use of undeclared identifier 'pctlnp' if (!pctlnp) ^ 1 error generated. vim +/pctlnp +614 drivers/gpio/gpio-rockchip.c 936ee2675eee1f Jianqun Xu 2021-08-16 579 936ee2675eee1f Jianqun Xu 2021-08-16 580 static int rockchip_gpiolib_register(struct rockchip_pin_bank *bank) 936ee2675eee1f Jianqun Xu 2021-08-16 581 { 936ee2675eee1f Jianqun Xu 2021-08-16 582 struct gpio_chip *gc; 936ee2675eee1f Jianqun Xu 2021-08-16 583 int ret; 936ee2675eee1f Jianqun Xu 2021-08-16 584 936ee2675eee1f Jianqun Xu 2021-08-16 585 bank->gpio_chip = rockchip_gpiolib_chip; 936ee2675eee1f Jianqun Xu 2021-08-16 586 936ee2675eee1f Jianqun Xu 2021-08-16 587 gc = &bank->gpio_chip; 936ee2675eee1f Jianqun Xu 2021-08-16 588 gc->base = bank->pin_base; 936ee2675eee1f Jianqun Xu 2021-08-16 589 gc->ngpio = bank->nr_pins; 936ee2675eee1f Jianqun Xu 2021-08-16 590 gc->label = bank->name; 936ee2675eee1f Jianqun Xu 2021-08-16 591 gc->parent = bank->dev; 936ee2675eee1f Jianqun Xu 2021-08-16 592 936ee2675eee1f Jianqun Xu 2021-08-16 593 ret = gpiochip_add_data(gc, bank); 936ee2675eee1f Jianqun Xu 2021-08-16 594 if (ret) { 936ee2675eee1f Jianqun Xu 2021-08-16 595 dev_err(bank->dev, "failed to add gpiochip %s, %d\n", 936ee2675eee1f Jianqun Xu 2021-08-16 596 gc->label, ret); 936ee2675eee1f Jianqun Xu 2021-08-16 597 return ret; 936ee2675eee1f Jianqun Xu 2021-08-16 598 } 936ee2675eee1f Jianqun Xu 2021-08-16 599 936ee2675eee1f Jianqun Xu 2021-08-16 600 /* 936ee2675eee1f Jianqun Xu 2021-08-16 601 * For DeviceTree-supported systems, the gpio core checks the 936ee2675eee1f Jianqun Xu 2021-08-16 602 * pinctrl's device node for the "gpio-ranges" property. 936ee2675eee1f Jianqun Xu 2021-08-16 603 * If it is present, it takes care of adding the pin ranges 936ee2675eee1f Jianqun Xu 2021-08-16 604 * for the driver. In this case the driver can skip ahead. 936ee2675eee1f Jianqun Xu 2021-08-16 605 * 936ee2675eee1f Jianqun Xu 2021-08-16 606 * In order to remain compatible with older, existing DeviceTree 936ee2675eee1f Jianqun Xu 2021-08-16 607 * files which don't set the "gpio-ranges" property or systems that 936ee2675eee1f Jianqun Xu 2021-08-16 608 * utilize ACPI the driver has to call gpiochip_add_pin_range(). 936ee2675eee1f Jianqun Xu 2021-08-16 609 */ 678cf6450de6a0 Andy Shevchenko 2022-08-30 610 if (!fwnode_property_read_bool(bank->fwnode, "gpio-ranges")) { 678cf6450de6a0 Andy Shevchenko 2022-08-30 611 struct fwnode_handle *parent = fwnode_get_parent(bank->fwnode); 936ee2675eee1f Jianqun Xu 2021-08-16 612 struct pinctrl_dev *pctldev = NULL; 936ee2675eee1f Jianqun Xu 2021-08-16 613 936ee2675eee1f Jianqun Xu 2021-08-16 @614 if (!pctlnp) 936ee2675eee1f Jianqun Xu 2021-08-16 615 return -ENODATA; 936ee2675eee1f Jianqun Xu 2021-08-16 616 678cf6450de6a0 Andy Shevchenko 2022-08-30 617 pctldev = of_pinctrl_get(to_of_node(parent)); 936ee2675eee1f Jianqun Xu 2021-08-16 618 if (!pctldev) 936ee2675eee1f Jianqun Xu 2021-08-16 619 return -ENODEV; 936ee2675eee1f Jianqun Xu 2021-08-16 620 936ee2675eee1f Jianqun Xu 2021-08-16 621 ret = gpiochip_add_pin_range(gc, dev_name(pctldev->dev), 0, 936ee2675eee1f Jianqun Xu 2021-08-16 622 gc->base, gc->ngpio); 936ee2675eee1f Jianqun Xu 2021-08-16 623 if (ret) { 936ee2675eee1f Jianqun Xu 2021-08-16 624 dev_err(bank->dev, "Failed to add pin range\n"); 936ee2675eee1f Jianqun Xu 2021-08-16 625 goto fail; 936ee2675eee1f Jianqun Xu 2021-08-16 626 } 936ee2675eee1f Jianqun Xu 2021-08-16 627 } 936ee2675eee1f Jianqun Xu 2021-08-16 628 936ee2675eee1f Jianqun Xu 2021-08-16 629 ret = rockchip_interrupts_register(bank); 936ee2675eee1f Jianqun Xu 2021-08-16 630 if (ret) { 936ee2675eee1f Jianqun Xu 2021-08-16 631 dev_err(bank->dev, "failed to register interrupt, %d\n", ret); 936ee2675eee1f Jianqun Xu 2021-08-16 632 goto fail; 936ee2675eee1f Jianqun Xu 2021-08-16 633 } 936ee2675eee1f Jianqun Xu 2021-08-16 634 936ee2675eee1f Jianqun Xu 2021-08-16 635 return 0; 936ee2675eee1f Jianqun Xu 2021-08-16 636 936ee2675eee1f Jianqun Xu 2021-08-16 637 fail: 936ee2675eee1f Jianqun Xu 2021-08-16 638 gpiochip_remove(&bank->gpio_chip); 936ee2675eee1f Jianqun Xu 2021-08-16 639 936ee2675eee1f Jianqun Xu 2021-08-16 640 return ret; 936ee2675eee1f Jianqun Xu 2021-08-16 641 } 936ee2675eee1f Jianqun Xu 2021-08-16 642 -- 0-DAY CI Kernel Test Service https://01.org/lkp