From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24489C38145 for ; Wed, 7 Sep 2022 15:38:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229920AbiIGPi2 (ORCPT ); Wed, 7 Sep 2022 11:38:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229958AbiIGPi0 (ORCPT ); Wed, 7 Sep 2022 11:38:26 -0400 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 732B18A6CB; Wed, 7 Sep 2022 08:38:25 -0700 (PDT) Received: by mail-ot1-f45.google.com with SMTP id t8-20020a9d5908000000b0063b41908168so10521554oth.8; Wed, 07 Sep 2022 08:38:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=KSoB0G6pzRD9DIaWPNDedKDIgG6tTjWjaUw36ufPm4w=; b=jLzB3um7Ct52eto1lBrsQO9dhG9K0S5ts6G2JgXiWzV95OU7MDuqD+czk0typ/4DrF dRYwQi6NHaz19VlWongvg9C/nWjJTKiEVoexe6uL1vCkjqwMn601m2BjNdM7lO1SbEMh JBedtChdnteNGGt5lnTFq2L/kTHdM4Aui3pzgARj1j/cp9CxLed/Zi7S55m2mLPmyHpK Ti3S5glwqr90ioYThVspBYJVajAT8B+NxLsQlncwdt+nCG+HnahvvDxJvsgNF77kLJZ2 7sQYConqjA3ZC63L8ToVq+Kb3w67bUfYXLBiAZxlhgHDGLOJjaLvmKVeTLzU7PFzLlHB +VQw== X-Gm-Message-State: ACgBeo25SIEwi/fYJEcX+0hscd8RN/6zHuYfKhy41L7JGuk5rKGdkbK0 3rcfp3r/9bxYOXlXoNoSRw== X-Google-Smtp-Source: AA6agR7cHntWzuv22mM6yjZi+6RNKL5IJKl5pY/iSsPF1rL/uA/vWpzkdCz2m1iQhfyCAPlQWPYbhw== X-Received: by 2002:a9d:5508:0:b0:636:ee02:ff7c with SMTP id l8-20020a9d5508000000b00636ee02ff7cmr1745217oth.249.1662565104411; Wed, 07 Sep 2022 08:38:24 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id bm23-20020a0568081a9700b0034480f7eec4sm6550747oib.12.2022.09.07.08.38.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 08:38:23 -0700 (PDT) Received: (nullmailer pid 3498322 invoked by uid 1000); Wed, 07 Sep 2022 15:38:23 -0000 Date: Wed, 7 Sep 2022 10:38:22 -0500 From: Rob Herring To: "Russell King (Oracle)" Cc: Arnd Bergmann , Lee Jones , Linus Walleij , Alyssa Rosenzweig , Andy Shevchenko , asahi@lists.linux.dev, Bartosz Golaszewski , devicetree@vger.kernel.org, Hector Martin , Jonathan Corbet , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-gpio@vger.kernel.org, Petr Mladek , Rasmus Villemoes , Sergey Senozhatsky , Steven Rostedt , Sven Peter Subject: Re: [PATCH 2/7] dt-bindings: gpio: add binding for the GPIO block for Apple Mac SMC Message-ID: <20220907153822.GA3492530-robh@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Sep 06, 2022 at 02:19:34PM +0100, Russell King (Oracle) wrote: > Add the DT binding for the Apple Mac System Management Controller GPIOs. > > Signed-off-by: Russell King (Oracle) > --- > .../devicetree/bindings/gpio/gpio-macsmc.yaml | 28 +++++++++++++++++++ > .../devicetree/bindings/mfd/apple,smc.yaml | 4 +++ > 2 files changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml b/Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml > new file mode 100644 > index 000000000000..ee620fe50ca8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml > @@ -0,0 +1,28 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/gpio-macsmc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple Mac System Management Controller GPIO > + > +maintainers: > + - Hector Martin > + > +description: > + This describes the binding for the Apple Mac System Management Controller > + GPIO block. > + > +properties: > + gpio-controller: true > + '#gpio-cells': > + const: 2 > + > +additionalProperties: false > + > +examples: > + - | > + smc_gpio: gpio { > + gpio-controller; > + #gpio-cells = <2>; > + }; Please move the example to the mfd schema. One complete example rather than piecemeal examples. > diff --git a/Documentation/devicetree/bindings/mfd/apple,smc.yaml b/Documentation/devicetree/bindings/mfd/apple,smc.yaml > index 168f237c2962..47e3cd58bf19 100644 > --- a/Documentation/devicetree/bindings/mfd/apple,smc.yaml > +++ b/Documentation/devicetree/bindings/mfd/apple,smc.yaml > @@ -37,6 +37,10 @@ title: Apple Mac System Management Controller > description: > A phandle to the mailbox channel > > +patternProperties: > + gpio: > + $ref: /schemas/gpio/gpio-macsmc.yaml > + Reorder the patches such that the MFD binding is last and this hunk can be part of it. Rob