* [PATCH v1 1/1] pinctrl: pistachio: Correct the fwnode_irq_get() return value check
@ 2022-09-08 9:43 Andy Shevchenko
2022-09-08 13:19 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2022-09-08 9:43 UTC (permalink / raw)
To: Andy Shevchenko, linux-gpio, linux-kernel; +Cc: Linus Walleij
fwnode_irq_get() may return all possible signed values, such as Linux
error code or 0. Fix the code to handle this properly.
Fixes: 1074e1d23a5c ("pinctrl: pistachio: Switch to use fwnode instead of")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/pinctrl-pistachio.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/pinctrl/pinctrl-pistachio.c b/drivers/pinctrl/pinctrl-pistachio.c
index 940ed3fff63a..7ca4ecb6eb8d 100644
--- a/drivers/pinctrl/pinctrl-pistachio.c
+++ b/drivers/pinctrl/pinctrl-pistachio.c
@@ -1374,8 +1374,14 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl)
ret = fwnode_irq_get(child, 0);
if (ret < 0) {
+ fwnode_handle_put(child);
+ dev_err(pctl->dev, "Failed to retrieve IRQ for bank %u\n", i);
+ goto err;
+ }
+ if (!ret) {
fwnode_handle_put(child);
dev_err(pctl->dev, "No IRQ for bank %u\n", i);
+ ret = -EINVAL;
goto err;
}
irq = ret;
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: pistachio: Correct the fwnode_irq_get() return value check
2022-09-08 9:43 [PATCH v1 1/1] pinctrl: pistachio: Correct the fwnode_irq_get() return value check Andy Shevchenko
@ 2022-09-08 13:19 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2022-09-08 13:19 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-gpio, linux-kernel
On Thu, Sep 8, 2022 at 11:43 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> fwnode_irq_get() may return all possible signed values, such as Linux
> error code or 0. Fix the code to handle this properly.
>
> Fixes: 1074e1d23a5c ("pinctrl: pistachio: Switch to use fwnode instead of")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-08 13:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-08 9:43 [PATCH v1 1/1] pinctrl: pistachio: Correct the fwnode_irq_get() return value check Andy Shevchenko
2022-09-08 13:19 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).