[PATCH v2 1/2] pinctrl: rockchip: find gpiochip by name from gpio module

Jianqun Xu
2022-09-17T03:32:47Z

Currently the pinctrl device acts as parent for the gpio devices for
rockchip platform, the pinctrl driver probes first and then populate the
gpio platform lastly.

This patch makes the pinctrl to populate gpio platform firstly and then
do probe after gpio probed successfully. And get gpiochips througth a
find function by the gpio label.

Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
---
v2:
- first version

drivers/pinctrl/pinctrl-rockchip.c | 48 +++++++++++++++++++++++-------
drivers/pinctrl/pinctrl-rockchip.h | 2 +-
2 files changed, 38 insertions(+), 12 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index a91061f9c2ac..5b828798bfa5 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -2726,7 +2726,7 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
{
struct rockchip_pinctrl *info = pinctrl_dev_get_drvdata(pctldev);
struct rockchip_pin_bank *bank = pin_to_bank(info, pin);
- struct gpio_chip *gpio = &bank->gpio_chip;
+ struct gpio_chip *gpio = bank->gpio_chip;
enum pin_config_param param;
u32 arg;
int i;
@@ -2832,7 +2832,7 @@ static int rockchip_pinconf_get(struct pinctrl_dev *pctldev, unsigned int pin,
{
struct rockchip_pinctrl *info = pinctrl_dev_get_drvdata(pctldev);
struct rockchip_pin_bank *bank = pin_to_bank(info, pin);
- struct gpio_chip *gpio = &bank->gpio_chip;
+ struct gpio_chip *gpio = bank->gpio_chip;
enum pin_config_param param = pinconf_to_config_param(*config);
u16 arg;
int rc;
@@ -3289,18 +3289,29 @@ static int __maybe_unused rockchip_pinctrl_resume(struct device *dev)
static SIMPLE_DEV_PM_OPS(rockchip_pinctrl_dev_pm_ops, rockchip_pinctrl_suspend,
rockchip_pinctrl_resume);

+static int gpiochip_match_name(struct gpio_chip *gc, void *data)
+{
+ const char *name = data;
+
+ return !strcmp(gc->label, name);
+}
+
static int rockchip_pinctrl_probe(struct platform_device *pdev)
{
- struct rockchip_pinctrl *info;
struct device *dev = &pdev->dev;
- struct device_node *np = dev->of_node, *node;
+ struct fwnode_handle *fwnode = dev_fwnode(dev);
+ struct rockchip_pinctrl *info;
struct rockchip_pin_ctrl *ctrl;
+ struct device_node *np, *node;
struct resource *res;
void __iomem *base;
- int ret;
+ int ret, i;

- if (!dev->of_node)
- return dev_err_probe(dev, -ENODEV, "device tree node not found\n");
+ if (is_of_node(fwnode)) {
+ ret = of_platform_populate(np, NULL, NULL, NULL);
+ if (ret)
+ return dev_err_probe(dev, ret, "failed to register gpio device\n");
+ }

info = devm_kzalloc(dev, sizeof(*info), GFP_KERNEL);
if (!info)
@@ -3358,11 +3369,26 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev)
if (ret)
return ret;

- platform_set_drvdata(pdev, info);
+ for (i = 0; i < ctrl->nr_banks; i++) {
+ struct gpio_chip *gc;
+ struct rockchip_pin_bank *bank = &ctrl->pin_banks[i];

- ret = of_platform_populate(np, NULL, NULL, &pdev->dev);
- if (ret)
- return dev_err_probe(dev, ret, "failed to register gpio device\n");
+ gc = gpiochip_find((void *)ctrl->pin_banks[i].name, gpiochip_match_name);
+ if (!gc) {
+ dev_err(dev, "fail to find gpiochip\n");
+ return ret;
+ }
+
+ ret = gpiochip_add_pin_range(gc, dev_name(dev), 0, gc->base, gc->ngpio);
+ if (ret) {
+ dev_err(dev, "fail to add pin range\n");
+ return ret;
+ }
+ bank->gpio_chip = gc;
+ }
+
+ platform_set_drvdata(pdev, info);
+ dev_info(dev, "probed %pfw\n", fwnode);

return 0;
}
diff --git a/drivers/pinctrl/pinctrl-rockchip.h b/drivers/pinctrl/pinctrl-rockchip.h
index 4759f336941e..2be12e76b2c4 100644
--- a/drivers/pinctrl/pinctrl-rockchip.h
+++ b/drivers/pinctrl/pinctrl-rockchip.h
@@ -330,7 +330,7 @@ struct rockchip_pin_bank {
struct device_node *of_node;
struct rockchip_pinctrl *drvdata;
struct irq_domain *domain;
- struct gpio_chip gpio_chip;
+ struct gpio_chip *gpio_chip;
struct pinctrl_gpio_range grange;
raw_spinlock_t slock;
const struct rockchip_gpio_regs *gpio_regs;
--
2.25.1