From: Tomer Maimon <tmaimon77@gmail.com>
To: <avifishman70@gmail.com>, <tali.perry1@gmail.com>,
<joel@jms.id.au>, <venture@google.com>, <yuenn@google.com>,
<benjaminfair@google.com>, <linus.walleij@linaro.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<j.neuschaefer@gmx.net>, <zhengbin13@huawei.com>
Cc: <openbmc@lists.ozlabs.org>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Tomer Maimon <tmaimon77@gmail.com>
Subject: [PATCH v3 0/2] pinctrl: nuvoton: add pinmux and GPIO driver for NPCM8XX
Date: Wed, 21 Sep 2022 12:50:51 +0300 [thread overview]
Message-ID: <20220921095053.88658-1-tmaimon77@gmail.com> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 2700 bytes --]
This patch set adds pinmux and GPIO controller for the Arbel NPCM8XX
Baseboard Management Controller (BMC).
Arbel BMC NPCM8XX pinctrl driver based on Poleg NPCM7XX, except the
pin mux mapping difference the NPCM8XX GPIO supports adjust debounce
period time.
Arbel BMC NPCM8XX Pinmux functions accessible only for pin groups
and pin configuration parameters available only for individual pins.
Arbel BMC NPCM8XX has eight identical GPIO modules,
each module has 32 GPIO ports.
Most of the GPIO ports are multiplexed with other system functions.
The NPCM8XX pinctrl and GPIO driver were tested on NPCM845 evaluation board.
Addressed comments from:
- Andy Shevchenko: https://lkml.org/lkml/2022/7/14/1218
- Rob Herring: https://lkml.org/lkml/2022/7/18/1165
- Krzysztof Kozlowski: https://lkml.org/lkml/2022/9/19/68
https://lkml.org/lkml/2022/7/14/757
Changes since version 2:
- Pin controller driver
- Modify kernel configuration.
- Adding and removing include files.
- Using the same register format size.
- Reducing lines by command combination.
- Remove unnecessary parentheses use.
- Use GENMASK and BIT macros.
- Using traditional patterns.
- Pin controller dt-binding
- Modify GPIO description.
- pintcrtl node name, Sorry, I know we have a long discussion about it.
Still, I think the best header pinctrl node name is pinctrl@f0800000.
because the pin mux is handled through the GCR.
BTW, same pinctrl header name is used in the NPCM7XX pinctrl version.
https://elixir.bootlin.com/linux/v6.0-rc6/source/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi#L560
Changes since version 1:
- Pin controller driver
- Remove unnecessary debug prints and comments.
- Use fwnode functions.
- Remove Redundant 'else'.
- Use switch case instead of else if.
- Use GENMASK and BIT macros.
- Use dev_err_probe in probe error.
- Use callback GPIO range.
- Add GCR phandle property.
- Parameter order in reversed xmas
- Pin controller dt-binding
- Modify name from pin to mux.
- Add phandle property.
Tomer Maimon (2):
dt-binding: pinctrl: Add NPCM8XX pinctrl and GPIO documentation
pinctrl: nuvoton: add NPCM8XX pinctrl and GPIO driver
.../pinctrl/nuvoton,npcm845-pinctrl.yaml | 213 ++
drivers/pinctrl/nuvoton/Kconfig | 14 +
drivers/pinctrl/nuvoton/Makefile | 1 +
drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c | 2485 +++++++++++++++++
4 files changed, 2713 insertions(+)
create mode 100644 Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml
create mode 100644 drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c
--
2.33.0
next reply other threads:[~2022-09-21 10:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 9:50 Tomer Maimon [this message]
2022-09-21 9:50 ` [PATCH v3 1/2] dt-binding: pinctrl: Add NPCM8XX pinctrl and GPIO documentation Tomer Maimon
2022-09-23 18:04 ` Krzysztof Kozlowski
2022-09-21 9:50 ` [PATCH v3 2/2] pinctrl: nuvoton: add NPCM8XX pinctrl and GPIO driver Tomer Maimon
2022-09-23 18:05 ` Krzysztof Kozlowski
2022-09-23 18:02 ` [PATCH v3 0/2] pinctrl: nuvoton: add pinmux and GPIO driver for NPCM8XX Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220921095053.88658-1-tmaimon77@gmail.com \
--to=tmaimon77@gmail.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).