From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Yang Yingliang <yangyingliang@huawei.com>,
<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<p.zabel@pengutronix.de>
Subject: Re: [PATCH -next v2 1/2] pinctrl: ocelot: add missing destroy_workqueue() in error path in ocelot_pinctrl_probe()
Date: Tue, 4 Oct 2022 11:11:53 +0200 [thread overview]
Message-ID: <20221004091153.eag6watgujngeows@soft-dev3-1.localhost> (raw)
In-Reply-To: <CACRpkdZdv2ATT8yTGKomXAUq5Pnkcex3Az4prVQVv87BTPs=CQ@mail.gmail.com>
The 10/04/2022 09:09, Linus Walleij wrote:
Hi Linus,
>
> On Sat, Sep 17, 2022 at 4:39 AM Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> > Add the missing destroy_workqueue() before return from ocelot_pinctrl_probe()
> > in error path.
> >
> > Fixes: c297561bc98a ("pinctrl: ocelot: Fix interrupt controller")
> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> > ---
> > v2:
> > move alloc_ordered_workqueue() after ocelot_pinctrl_register().
>
> Horatiu does this v2 look like you want it? Reviewed-by?
I have noticed that Yang has sent another version (v3)[1] where he makes
uses of devm_add_action_or_reset.
[1] https://lore.kernel.org/all/20220925021258.1492905-1-yangyingliang@huawei.com/T/
>
> Yours,
> Linus Walleij
--
/Horatiu
prev parent reply other threads:[~2022-10-04 9:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 2:46 [PATCH -next v2 1/2] pinctrl: ocelot: add missing destroy_workqueue() in error path in ocelot_pinctrl_probe() Yang Yingliang
2022-09-17 2:46 ` [PATCH -next v2 2/2] pinctrl: ocelot: Use devm_platform_get_and_ioremap_resource() Yang Yingliang
2022-09-17 8:55 ` andy.shevchenko
2022-09-17 8:54 ` [PATCH -next v2 1/2] pinctrl: ocelot: add missing destroy_workqueue() in error path in ocelot_pinctrl_probe() andy.shevchenko
2022-09-17 11:19 ` Yang Yingliang
2022-10-04 7:09 ` Linus Walleij
2022-10-04 9:11 ` Horatiu Vultur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221004091153.eag6watgujngeows@soft-dev3-1.localhost \
--to=horatiu.vultur@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).