* [PATCH v1 1/1] pinctrl: intel: Use str_enable_disable() helper
@ 2022-10-17 17:15 Andy Shevchenko
2022-10-18 8:30 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2022-10-17 17:15 UTC (permalink / raw)
To: Andy Shevchenko, linux-gpio, linux-kernel
Cc: Mika Westerberg, Andy Shevchenko, Linus Walleij
Use str_enable_disable() helper instead of open coding the same.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-intel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index 3695d7cb1d01..e9f4f95913ab 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -15,6 +15,7 @@
#include <linux/platform_device.h>
#include <linux/property.h>
#include <linux/seq_file.h>
+#include <linux/string_helpers.h>
#include <linux/time.h>
#include <linux/pinctrl/consumer.h>
@@ -1171,7 +1172,7 @@ static int intel_gpio_irq_wake(struct irq_data *d, unsigned int on)
else
disable_irq_wake(pctrl->irq);
- dev_dbg(pctrl->dev, "%sable wake for pin %u\n", on ? "en" : "dis", pin);
+ dev_dbg(pctrl->dev, "%s wake for pin %u\n", str_enable_disable(on), pin);
return 0;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: intel: Use str_enable_disable() helper
2022-10-17 17:15 [PATCH v1 1/1] pinctrl: intel: Use str_enable_disable() helper Andy Shevchenko
@ 2022-10-18 8:30 ` Linus Walleij
2022-10-26 13:44 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2022-10-18 8:30 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-gpio, linux-kernel, Mika Westerberg, Andy Shevchenko
On Mon, Oct 17, 2022 at 7:14 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> Use str_enable_disable() helper instead of open coding the same.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: intel: Use str_enable_disable() helper
2022-10-18 8:30 ` Linus Walleij
@ 2022-10-26 13:44 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2022-10-26 13:44 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, linux-kernel, Mika Westerberg
On Tue, Oct 18, 2022 at 10:30:09AM +0200, Linus Walleij wrote:
> On Mon, Oct 17, 2022 at 7:14 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>
> > Use str_enable_disable() helper instead of open coding the same.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-26 13:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-17 17:15 [PATCH v1 1/1] pinctrl: intel: Use str_enable_disable() helper Andy Shevchenko
2022-10-18 8:30 ` Linus Walleij
2022-10-26 13:44 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).