From: Richard Acayan <mailingradian@gmail.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-gpio@vger.kernel.org, mailingradian@gmail.com,
linus.walleij@linaro.org
Subject: [PATCH -next] pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static
Date: Thu, 20 Oct 2022 17:04:44 -0400 [thread overview]
Message-ID: <20221020210444.3736-1-mailingradian@gmail.com> (raw)
In-Reply-To: <20221020075650.1031228-1-yangyingliang@huawei.com>
> sdm670_reserved_gpios is only used in pinctrl-sdm670.c now, change it
> to static.
>
> Fixes: 61164d220f52 ("pinctrl: qcom: add sdm670 pinctrl")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
The email headers could maybe use a little work.
From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-gpio@vger.kernel.org>
CC: <mailingradian@gmail.com>, <linus.walleij@linaro.org>,
<yangyingliang@huawei.com>
Subject: [PATCH -next] pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static
You don't need to remove people's names from their email addresses; they can go
together like so (not a strict requirement, but a nice touch in everyone's
mailboxes):
CC: Richard Acayan <mailingradian@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Yang Yingliang <yangyingliang@huawei.com>
For this patch, there is a typo in the subject:
-Subject: [PATCH -next] pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static
+Subject: [PATCH -next] pinctrl: qcom: sdm670: change sdm670_reserved_gpios to static
Otherwise, it looks good.
Acked-by: Richard Acayan <mailingradian@gmail.com>
> ---
> drivers/pinctrl/qcom/pinctrl-sdm670.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sdm670.c b/drivers/pinctrl/qcom/pinctrl-sdm670.c
> index 4c3c3782fef8..b888bca7ecd7 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sdm670.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sdm670.c
> @@ -1294,7 +1294,7 @@ static const struct msm_pingroup sdm670_groups[] = {
> SDC_QDSD_PINGROUP(sdc2_data, 0x9a000, 9, 0),
> };
>
> -const int sdm670_reserved_gpios[] = {
> +static const int sdm670_reserved_gpios[] = {
> 58, 59, 60, 61, 62, 63, 64, 69, 70, 71, 72, 73, 74, 104, -1
> };
>
> --
> 2.25.1
next prev parent reply other threads:[~2022-10-20 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 7:56 [PATCH -next] pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static Yang Yingliang
2022-10-20 21:04 ` Richard Acayan [this message]
2022-10-24 8:19 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020210444.3736-1-mailingradian@gmail.com \
--to=mailingradian@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).