* [PATCH] pinctrl: samsung: remove variable pin
@ 2022-10-24 13:15 Colin Ian King
2022-10-24 13:29 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-10-24 13:15 UTC (permalink / raw)
To: Krzysztof Kozlowski, Alim Akhtar, Tomasz Figa, Sylwester Nawrocki,
Linus Walleij, linux-arm-kernel, linux-samsung-soc, linux-gpio
Cc: kernel-janitors, linux-kernel
Variable pin is just being incremented and it's never used
anywhere else. The variable and the increment are redundant so
remove it.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
index 625cb1065eaf..78b7bd133566 100644
--- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
+++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
@@ -509,7 +509,6 @@ static int s3c24xx_eint_init(struct samsung_pinctrl_drv_data *d)
struct s3c24xx_eint_domain_data *ddata;
unsigned int mask;
unsigned int irq;
- unsigned int pin;
if (bank->eint_type != EINT_TYPE_WKUP)
continue;
@@ -534,7 +533,7 @@ static int s3c24xx_eint_init(struct samsung_pinctrl_drv_data *d)
irq = bank->eint_offset;
mask = bank->eint_mask;
- for (pin = 0; mask; ++pin, mask >>= 1) {
+ for (; mask; mask >>= 1) {
if (irq >= NUM_EINT)
break;
if (!(mask & 1))
--
2.37.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: samsung: remove variable pin
2022-10-24 13:15 [PATCH] pinctrl: samsung: remove variable pin Colin Ian King
@ 2022-10-24 13:29 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-24 13:29 UTC (permalink / raw)
To: Colin Ian King, Alim Akhtar, Tomasz Figa, Sylwester Nawrocki,
Linus Walleij, linux-arm-kernel, linux-samsung-soc, linux-gpio
Cc: kernel-janitors, linux-kernel
On 24/10/2022 09:15, Colin Ian King wrote:
> Variable pin is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Thanks for the patch. The file is being in process of dropping (patchset
is being reviewed), so I think we can skip all the fixes.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-24 18:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-24 13:15 [PATCH] pinctrl: samsung: remove variable pin Colin Ian King
2022-10-24 13:29 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).