linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-pwm@vger.kernel.org
Cc: Andy Shevchenko <andy@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH v2 3/6] pwm: lpss: Include headers we are direct user of
Date: Tue,  8 Nov 2022 16:22:23 +0200	[thread overview]
Message-ID: <20221108142226.63161-4-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20221108142226.63161-1-andriy.shevchenko@linux.intel.com>

For the sake of integrity, include headers we are direct user of.

While at it, move the struct pwm_lpss_chip to be after
the struct pwm_lpss_boardinfo as the former uses pointer
to the latter.

Replace device.h with a forward declaration in order to improve
the compilation time due to reducing overhead of device.h parsing
with entire train of dependencies.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/pwm/pwm-lpss.h | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/drivers/pwm/pwm-lpss.h b/drivers/pwm/pwm-lpss.h
index 2c746c51b883..4561d229b27d 100644
--- a/drivers/pwm/pwm-lpss.h
+++ b/drivers/pwm/pwm-lpss.h
@@ -10,16 +10,12 @@
 #ifndef __PWM_LPSS_H
 #define __PWM_LPSS_H
 
-#include <linux/device.h>
 #include <linux/pwm.h>
+#include <linux/types.h>
 
-#define LPSS_MAX_PWMS			4
+struct device;
 
-struct pwm_lpss_chip {
-	struct pwm_chip chip;
-	void __iomem *regs;
-	const struct pwm_lpss_boardinfo *info;
-};
+#define LPSS_MAX_PWMS			4
 
 struct pwm_lpss_boardinfo {
 	unsigned long clk_rate;
@@ -43,6 +39,12 @@ extern const struct pwm_lpss_boardinfo pwm_lpss_bsw_info;
 extern const struct pwm_lpss_boardinfo pwm_lpss_bxt_info;
 extern const struct pwm_lpss_boardinfo pwm_lpss_tng_info;
 
+struct pwm_lpss_chip {
+	struct pwm_chip chip;
+	void __iomem *regs;
+	const struct pwm_lpss_boardinfo *info;
+};
+
 struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev, void __iomem *base,
 				     const struct pwm_lpss_boardinfo *info);
 
-- 
2.35.1


  parent reply	other threads:[~2022-11-08 14:22 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08 14:22 [PATCH v2 0/6] pinctrl: intel: Enable PWM optional feature Andy Shevchenko
2022-11-08 14:22 ` [PATCH v2 1/6] pwm: Add a stub for devm_pwmchip_add() Andy Shevchenko
2022-11-10  7:07   ` Uwe Kleine-König
2022-11-10  9:54     ` Andy Shevchenko
2022-11-08 14:22 ` [PATCH v2 2/6] pwm: lpss: Rename MAX_PWMS --> LPSS_MAX_PWMS Andy Shevchenko
2022-11-08 15:07   ` Uwe Kleine-König
2022-11-08 14:22 ` Andy Shevchenko [this message]
2022-11-10  7:21   ` [PATCH v2 3/6] pwm: lpss: Include headers we are direct user of Uwe Kleine-König
2022-11-10  9:53     ` Andy Shevchenko
2022-11-10 10:20       ` Uwe Kleine-König
2022-11-10 10:24         ` Andy Shevchenko
2022-11-08 14:22 ` [PATCH v2 4/6] pwm: lpss: Allow other drivers to enable PWM LPSS Andy Shevchenko
2022-11-10  7:28   ` Uwe Kleine-König
2022-11-10  7:35     ` Uwe Kleine-König
2022-11-10  9:58     ` Andy Shevchenko
2022-11-10 10:23       ` Uwe Kleine-König
2022-11-11 13:50         ` Andy Shevchenko
2022-11-08 14:22 ` [PATCH v2 5/6] pwm: lpss: Add pwm_lpss_probe() stub Andy Shevchenko
2022-11-10  7:38   ` Uwe Kleine-König
2022-11-10 10:01     ` Andy Shevchenko
2022-11-11 13:57       ` Andy Shevchenko
2022-11-08 14:22 ` [PATCH v2 6/6] pinctrl: intel: Enumerate PWM device when community has a capabilitty Andy Shevchenko
2022-11-09  9:08   ` Linus Walleij
2022-11-09  9:56     ` Andy Shevchenko
2022-11-09 10:08       ` Linus Walleij
2022-11-09 10:40         ` Andy Shevchenko
2022-11-10  7:44   ` Uwe Kleine-König
2022-11-10 10:03     ` Andy Shevchenko
2022-11-09  9:01 ` [PATCH v2 0/6] pinctrl: intel: Enable PWM optional feature Linus Walleij
2022-11-09 17:40 ` Thierry Reding
2022-11-09 17:49   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221108142226.63161-4-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).