linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-pwm@vger.kernel.org
Cc: Andy Shevchenko <andy@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH v2 6/6] pinctrl: intel: Enumerate PWM device when community has a capabilitty
Date: Tue,  8 Nov 2022 16:22:26 +0200	[thread overview]
Message-ID: <20221108142226.63161-7-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20221108142226.63161-1-andriy.shevchenko@linux.intel.com>

Some of the Communities may have PWM capability. In such cases,
enumerate PWM device via respective driver. User is still responsible
for setting correct pin muxing for the line that needs to output the
signal.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/pinctrl/intel/pinctrl-intel.c | 29 +++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index 6e630e87fed6..6b685ff7041f 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -24,6 +24,8 @@
 #include <linux/pinctrl/pinctrl.h>
 #include <linux/pinctrl/pinmux.h>
 
+#include <linux/platform_data/x86/pwm-lpss.h>
+
 #include "../core.h"
 #include "pinctrl-intel.h"
 
@@ -49,6 +51,8 @@
 #define PADOWN_MASK(p)			(GENMASK(3, 0) << PADOWN_SHIFT(p))
 #define PADOWN_GPP(p)			((p) / 8)
 
+#define PWMC				0x204
+
 /* Offset from pad_regs */
 #define PADCFG0				0x000
 #define PADCFG0_RXEVCFG_SHIFT		25
@@ -1502,6 +1506,27 @@ static int intel_pinctrl_pm_init(struct intel_pinctrl *pctrl)
 	return 0;
 }
 
+static int intel_pinctrl_probe_pwm(struct intel_pinctrl *pctrl,
+				   struct intel_community *community)
+{
+	static const struct pwm_lpss_boardinfo info = {
+		.clk_rate = 19200000,
+		.npwm = 1,
+		.base_unit_bits = 22,
+		.bypass = true,
+	};
+	struct pwm_lpss_chip *pwm;
+
+	if (!(community->features & PINCTRL_FEATURE_PWM))
+		return 0;
+
+	pwm = pwm_lpss_probe(pctrl->dev, community->regs + PWMC, &info);
+	if (IS_ERR(pwm) && PTR_ERR(pwm) != -ENODEV)
+		return PTR_ERR(pwm);
+
+	return 0;
+}
+
 static int intel_pinctrl_probe(struct platform_device *pdev,
 			       const struct intel_pinctrl_soc_data *soc_data)
 {
@@ -1588,6 +1613,10 @@ static int intel_pinctrl_probe(struct platform_device *pdev,
 			ret = intel_pinctrl_add_padgroups_by_size(pctrl, community);
 		if (ret)
 			return ret;
+
+		ret = intel_pinctrl_probe_pwm(pctrl, community);
+		if (ret)
+			return ret;
 	}
 
 	irq = platform_get_irq(pdev, 0);
-- 
2.35.1


  parent reply	other threads:[~2022-11-08 14:22 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08 14:22 [PATCH v2 0/6] pinctrl: intel: Enable PWM optional feature Andy Shevchenko
2022-11-08 14:22 ` [PATCH v2 1/6] pwm: Add a stub for devm_pwmchip_add() Andy Shevchenko
2022-11-10  7:07   ` Uwe Kleine-König
2022-11-10  9:54     ` Andy Shevchenko
2022-11-08 14:22 ` [PATCH v2 2/6] pwm: lpss: Rename MAX_PWMS --> LPSS_MAX_PWMS Andy Shevchenko
2022-11-08 15:07   ` Uwe Kleine-König
2022-11-08 14:22 ` [PATCH v2 3/6] pwm: lpss: Include headers we are direct user of Andy Shevchenko
2022-11-10  7:21   ` Uwe Kleine-König
2022-11-10  9:53     ` Andy Shevchenko
2022-11-10 10:20       ` Uwe Kleine-König
2022-11-10 10:24         ` Andy Shevchenko
2022-11-08 14:22 ` [PATCH v2 4/6] pwm: lpss: Allow other drivers to enable PWM LPSS Andy Shevchenko
2022-11-10  7:28   ` Uwe Kleine-König
2022-11-10  7:35     ` Uwe Kleine-König
2022-11-10  9:58     ` Andy Shevchenko
2022-11-10 10:23       ` Uwe Kleine-König
2022-11-11 13:50         ` Andy Shevchenko
2022-11-08 14:22 ` [PATCH v2 5/6] pwm: lpss: Add pwm_lpss_probe() stub Andy Shevchenko
2022-11-10  7:38   ` Uwe Kleine-König
2022-11-10 10:01     ` Andy Shevchenko
2022-11-11 13:57       ` Andy Shevchenko
2022-11-08 14:22 ` Andy Shevchenko [this message]
2022-11-09  9:08   ` [PATCH v2 6/6] pinctrl: intel: Enumerate PWM device when community has a capabilitty Linus Walleij
2022-11-09  9:56     ` Andy Shevchenko
2022-11-09 10:08       ` Linus Walleij
2022-11-09 10:40         ` Andy Shevchenko
2022-11-10  7:44   ` Uwe Kleine-König
2022-11-10 10:03     ` Andy Shevchenko
2022-11-09  9:01 ` [PATCH v2 0/6] pinctrl: intel: Enable PWM optional feature Linus Walleij
2022-11-09 17:40 ` Thierry Reding
2022-11-09 17:49   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221108142226.63161-7-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).