From: Rob Herring <robh@kernel.org>
To: Yinbo Zhu <zhuyinbo@loongson.cn>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linus Walleij <linus.walleij@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
zhanghongchen <zhanghongchen@loongson.cn>
Subject: Re: [PATCH v10 1/2] pinctrl: pinctrl-loongson2: add pinctrl driver support
Date: Tue, 15 Nov 2022 07:38:40 -0600 [thread overview]
Message-ID: <20221115133840.GA861387-robh@kernel.org> (raw)
In-Reply-To: <20221114024942.8111-1-zhuyinbo@loongson.cn>
On Mon, Nov 14, 2022 at 10:49:41AM +0800, Yinbo Zhu wrote:
> From: zhanghongchen <zhanghongchen@loongson.cn>
>
> The Loongson-2 SoC has a few pins that can be used as GPIOs or take
> multiple other functions. Add a driver for the pinmuxing.
>
> There is currently no support for GPIO pin pull-up and pull-down.
>
> Signed-off-by: zhanghongchen <zhanghongchen@loongson.cn>
> Co-developed-by: Yinbo Zhu <zhuyinbo@loongson.cn>
> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
> ---
> Change in v10:
> 1. Remove lio/uart2/uart1/carmera/dvo1/dvo0 pins resue configuration.
> 2. Remove the castings about readl/writel/definition addr.
> Change in v9:
> 1. Add zhanghongchen as patch author and add Co-developed-by tag
> for myself.
> 2. Keep entry in order in Kconfig and Makefile.
> 3. Keep it as a separate group after generic linux/* ones.
> 4. Use linux/io.h replace asm-generic/io.h.
> 5. Use PINCTRL_PINGROUP() and associated data structure.
> 6. Remove Redundant blank line after loongson2_pmx_groups.
> 7. Adjust gpio_groups.
> 8. Remove message printk after devm_platform_ioremap_resource.
> 9. Remove comma for the terminator line.
> 10. Add MODULE_LICENSE("GPL") in driver ending.
> Change in v8:
> 1. Add #include <linux/pinctrl/pinctrl.h>.
> 2. Add #include <linux/seq_file.h>.
> Change in v7:
> 1. Add all history change log information.
Linus applied v7 already. Additional changes need to be incremental
patches on top of it.
Rob
next prev parent reply other threads:[~2022-11-15 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 2:49 [PATCH v10 1/2] pinctrl: pinctrl-loongson2: add pinctrl driver support Yinbo Zhu
2022-11-14 2:49 ` [PATCH v10 2/2] dt-bindings: pinctrl: add loongson-2 pinctrl Yinbo Zhu
2022-11-17 7:53 ` Yinbo Zhu
2022-11-15 13:38 ` Rob Herring [this message]
2022-11-16 7:39 ` [PATCH v10 1/2] pinctrl: pinctrl-loongson2: add pinctrl driver support Yinbo Zhu
2022-11-17 7:51 ` Yinbo Zhu
2022-11-17 9:25 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221115133840.GA861387-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=zhanghongchen@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).