From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96EEDC4332F for ; Fri, 18 Nov 2022 18:08:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241807AbiKRSIV (ORCPT ); Fri, 18 Nov 2022 13:08:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241377AbiKRSIU (ORCPT ); Fri, 18 Nov 2022 13:08:20 -0500 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE1E37A366; Fri, 18 Nov 2022 10:08:18 -0800 (PST) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2AII89BT082440; Fri, 18 Nov 2022 12:08:09 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1668794889; bh=c3pepiCGHi5sR3q5cWaJ4aW11UIBytKWyekMYxdOLOs=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=CMKUFa98XMCKaueIg8aDc95Jj2VC3nJFFFSEMwy2sdBN5nkYicU2A+TU3l4vhDd0W 5NSUnj5ShSiiUbhpcufuJc/73XNf1vt0ZXjL6j1cB5NsDjDTjmkoJfhucoKx0i7ty5 sSrDHULjldhCzWicVIouvYYWwhNjVIKFw/X1/xy0= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2AII898T054230 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 18 Nov 2022 12:08:09 -0600 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 18 Nov 2022 12:08:08 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 18 Nov 2022 12:08:08 -0600 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2AII88Io123565; Fri, 18 Nov 2022 12:08:08 -0600 Date: Fri, 18 Nov 2022 12:08:08 -0600 From: Nishanth Menon To: Andrew Davis CC: Apurva Nandan , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Linus Walleij , , , , , Hari Nagalla Subject: Re: [PATCH v3 4/4] arm64: dts: ti: Add support for J784S4 EVM board Message-ID: <20221118180808.wnel7d6gswsnooww@junkman> References: <20221116130428.161329-1-a-nandan@ti.com> <20221116130428.161329-5-a-nandan@ti.com> <20221118174754.y37pq77drvla2uxj@tinderbox> <8c123fa2-caab-d2dd-5eb4-688f1c6abb33@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <8c123fa2-caab-d2dd-5eb4-688f1c6abb33@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 11:56-20221118, Andrew Davis wrote: > On 11/18/22 11:47 AM, Nishanth Menon wrote: > > On 11:40-20221118, Andrew Davis wrote: > > > On 11/16/22 7:04 AM, Apurva Nandan wrote: > > > > [...] > > > > > > +#include > > > > +#include > > > > +#include "k3-j784s4.dtsi" > > > > + > > > > +/ { > > > > + compatible = "ti,j784s4-evm", "ti,j784s4"; > > > > + model = "Texas Instruments J784S4 EVM"; > > > > + > > > > + chosen { > > > > + stdout-path = "serial2:115200n8"; > > > > + }; > > > > + > > > > + aliases { > > > > + serial2 = &main_uart8; > > > > > > This feels hacky. Your chosen node picks serial2 as that is usually > > > the one that is wired up on K3 boards. But on this board it is main_uart8. > > > So why not have this be serial10, then choose > > > > > > stdout-path = "serial10:115200n8"; > > > > > > Also, I've made comments on previous version of this series, it is > > > nice to include folks who have commented before in the CC for future > > > versions, that way our filters don't hide these away and we can more > > > easily check that our comments have been addressed. > > > > Please stick with the standard of serial2 as the linux console standard. > > We ended up with that to ease up capabilities of various distros to > > uniformly work across SoC and board variants. > > > > The chosen "stdout-path" is for setting the kernel's default output terminal. > Distros and other userspaces need to use their own policy mechanisms for > picking what serial port to run getty on or whatever the issue may be. > > Some look at the kernel command line, and our bootloader provides > that too, so still no reason to fake alias names here. We have had this conversation earlier as well. https://lore.kernel.org/linux-arm-kernel/CAK8P3a2VSBvOn1o+q1PYZaQ6LS9U4cz+DZGuDbisHkwNs2dAAw@mail.gmail.com/T/#m4ecb0dc6a78c84631f072faa1b0df0df46333d09 This is also the reason why we picked serial2 as linux console as a standard across the boards based on the ecosystem. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D