From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-pwm@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v5 6/7] pwm: lpss: Add devm_pwm_lpss_probe() stub
Date: Tue, 22 Nov 2022 19:14:44 +0100 [thread overview]
Message-ID: <20221122181444.m74fa47ejp7nvgxj@pengutronix.de> (raw)
In-Reply-To: <Y30IaslnbeKBkMhM@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]
Hello Andy,
On Tue, Nov 22, 2022 at 07:35:38PM +0200, Andy Shevchenko wrote:
> On Tue, Nov 22, 2022 at 05:47:03PM +0100, Uwe Kleine-König wrote:
> > On Thu, Nov 17, 2022 at 01:08:05PM +0200, Andy Shevchenko wrote:
> > > In case the PWM LPSS module is not provided, allow users to be
> > > compiled with the help of the devm_pwm_lpss_probe() stub.
>
> ...
>
> > > +static inline
> > > +struct pwm_lpss_chip *devm_pwm_lpss_probe(struct device *dev, void __iomem *base,
> > > + const struct pwm_lpss_boardinfo *info)
> > > +{
> > > + return ERR_PTR(-ENODEV);
> > > +}
> > > +#endif /* CONFIG_PWM_LPSS */
> >
> > Hmm, this is actually never used, because if
> > !IS_REACHABLE(CONFIG_PWM_LPSS), the only caller (that is added in patch
> > 7) has:
> >
> > if (!IS_REACHABLE(CONFIG_PWM_LPSS))
> > return 0;
> >
> > before devm_pwm_lpss_probe() is called.
> >
> > Not sure if it's safe to just drop this patch.
>
> How is it supposed to be compiled and linked then?
The compiler optimizes everything away after that return 0 and so
doesn't need that symbol at all.
I just tested compiling your series without patch #6, x86_64 allmodconfig + PWM=n.
nm doesn't report the need for devm_pwm_lpss_probe in
drivers/pinctrl/intel/pinctrl-intel.o.
The build isn't done yet, but I don't expect surprises.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-11-22 18:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 11:07 [PATCH v5 0/7] pinctrl: intel: Enable PWM optional feature Andy Shevchenko
2022-11-17 11:08 ` [PATCH v5 1/7] pwm: Add a stub for devm_pwmchip_add() Andy Shevchenko
2022-11-17 11:08 ` [PATCH v5 2/7] pwm: lpss: Rename MAX_PWMS --> LPSS_MAX_PWMS Andy Shevchenko
2022-11-17 11:08 ` [PATCH v5 3/7] pwm: lpss: Include headers we are the direct user of Andy Shevchenko
2022-11-22 13:39 ` Uwe Kleine-König
2022-11-22 14:34 ` Andy Shevchenko
2022-11-17 11:08 ` [PATCH v5 4/7] pwm: lpss: Allow other drivers to enable PWM LPSS Andy Shevchenko
2022-11-17 11:08 ` [PATCH v5 5/7] pwm: lpss: Rename pwm_lpss_probe() --> devm_pwm_lpss_probe() Andy Shevchenko
2022-11-17 11:08 ` [PATCH v5 6/7] pwm: lpss: Add devm_pwm_lpss_probe() stub Andy Shevchenko
2022-11-22 16:47 ` Uwe Kleine-König
2022-11-22 17:35 ` Andy Shevchenko
2022-11-22 18:14 ` Uwe Kleine-König [this message]
2022-11-22 18:32 ` Andy Shevchenko
2022-11-22 20:21 ` Uwe Kleine-König
2022-11-17 11:08 ` [PATCH v5 7/7] pinctrl: intel: Enumerate PWM device when community has a capability Andy Shevchenko
2022-11-22 13:00 ` [PATCH v5 0/7] pinctrl: intel: Enable PWM optional feature Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122181444.m74fa47ejp7nvgxj@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).