linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cixi Geng <cixi.geng@linux.dev>
To: linus.walleij@linaro.org, brgl@bgdev.pl, orsonzhai@gmail.com,
	baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	cixi.geng1@unisoc.com
Subject: [PATCH V4 0/3] Make the irqchip immutable
Date: Thu, 29 Dec 2022 22:55:42 +0800	[thread overview]
Message-ID: <20221229145545.14055-1-cixi.geng@linux.dev> (raw)

From: Cixi Geng <cixi.geng1@unisoc.com>

Kernel warns about mutable irq_chips:
    "not an immutable chip, please consider fixing!"

Make the struct irq_chip const, flag it as IRQCHIP_IMMUTABLE, add the
new helper functions, and call the appropriate gpiolib functions.

v2 changes:
Split the patch by each driver. and other comment by baolin in[1]

v3 changes:
Fix cocci warnings test by lkp[2].

v4 changes:
Change the irq name.
Keep the same coding style by using offset for irqd_to_hwirq(data)
Add Reviewed-by tag.

[1]:https://lore.kernel.org/all/97e244d4-6b5c-31c9-7329-b8deef615645@linux.alibaba.com/
[2]:https://lore.kernel.org/all/202212240406.9Nm190P8-lkp@intel.com/

Cixi Geng (3):
  gpio: eic-sprd: Make the irqchip immutable
  gpio: gpio-pmic-eic-sprd: Make the irqchip immutable
  gpio: gpio-sprd: Make the irqchip immutable

 drivers/gpio/gpio-eic-sprd.c      | 23 ++++++++++++++---------
 drivers/gpio/gpio-pmic-eic-sprd.c | 29 ++++++++++++++++++-----------
 drivers/gpio/gpio-sprd.c          |  9 ++++++---
 3 files changed, 38 insertions(+), 23 deletions(-)


base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
-- 
2.34.1


             reply	other threads:[~2022-12-29 14:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-29 14:55 Cixi Geng [this message]
2022-12-29 14:55 ` [PATCH V4 1/3] gpio: eic-sprd: Make the irqchip immutable Cixi Geng
2022-12-29 14:55 ` [PATCH V4 2/3] gpio: gpio-pmic-eic-sprd: " Cixi Geng
2022-12-29 14:55 ` [PATCH V4 3/3] gpio: gpio-sprd: " Cixi Geng
2022-12-30 15:59 ` [PATCH V4 0/3] " Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221229145545.14055-1-cixi.geng@linux.dev \
    --to=cixi.geng@linux.dev \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=brgl@bgdev.pl \
    --cc=cixi.geng1@unisoc.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=orsonzhai@gmail.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).