linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pinctrl: stm32: Fix refcount leak in stm32_pctrl_get_irq_domain
@ 2023-01-02  8:24 Miaoqian Lin
  2023-01-09 14:13 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2023-01-02  8:24 UTC (permalink / raw)
  To: Linus Walleij, Maxime Coquelin, Alexandre Torgue, Fabien Dessenne,
	Andy Shevchenko, Marek Vasut, Miaoqian Lin, linux-gpio,
	linux-stm32, linux-arm-kernel, linux-kernel

of_irq_find_parent() returns a node pointer with refcount incremented,
We should use of_node_put() on it when not needed anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: d86f4d71e42a ("pinctrl: stm32: check irq controller availability at probe")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 drivers/pinctrl/stm32/pinctrl-stm32.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c
index 1cddca506ad7..cb33a23ab0c1 100644
--- a/drivers/pinctrl/stm32/pinctrl-stm32.c
+++ b/drivers/pinctrl/stm32/pinctrl-stm32.c
@@ -1382,6 +1382,7 @@ static struct irq_domain *stm32_pctrl_get_irq_domain(struct platform_device *pde
 		return ERR_PTR(-ENXIO);
 
 	domain = irq_find_host(parent);
+	of_node_put(parent);
 	if (!domain)
 		/* domain not registered yet */
 		return ERR_PTR(-EPROBE_DEFER);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] pinctrl: stm32: Fix refcount leak in stm32_pctrl_get_irq_domain
  2023-01-02  8:24 [PATCH] pinctrl: stm32: Fix refcount leak in stm32_pctrl_get_irq_domain Miaoqian Lin
@ 2023-01-09 14:13 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2023-01-09 14:13 UTC (permalink / raw)
  To: Miaoqian Lin
  Cc: Maxime Coquelin, Alexandre Torgue, Fabien Dessenne,
	Andy Shevchenko, Marek Vasut, linux-gpio, linux-stm32,
	linux-arm-kernel, linux-kernel

On Mon, Jan 2, 2023 at 9:25 AM Miaoqian Lin <linmq006@gmail.com> wrote:

> of_irq_find_parent() returns a node pointer with refcount incremented,
> We should use of_node_put() on it when not needed anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: d86f4d71e42a ("pinctrl: stm32: check irq controller availability at probe")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

Patch applied!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-09 14:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-02  8:24 [PATCH] pinctrl: stm32: Fix refcount leak in stm32_pctrl_get_irq_domain Miaoqian Lin
2023-01-09 14:13 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).