From: Rob Herring <robh@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v1 1/1] gpiolib: of: Move enum of_gpio_flags to its only user
Date: Fri, 13 Jan 2023 14:23:51 -0600 [thread overview]
Message-ID: <20230113202351.GA2864676-robh@kernel.org> (raw)
In-Reply-To: <Y8AzwdCGr4VFjP5X@smile.fi.intel.com>
On Thu, Jan 12, 2023 at 06:22:25PM +0200, Andy Shevchenko wrote:
> On Thu, Jan 12, 2023 at 04:51:40PM +0200, Andy Shevchenko wrote:
> > GPIO library for OF is the only user for enum of_gpio_flags.
> > Move it there.
>
> ...
>
> > +/*
> > + * This is Linux-specific flags. By default controllers' and Linux' mapping
> > + * match, but GPIO controllers are free to translate their own flags to
> > + * Linux-specific in their .xlate callback. Though, 1:1 mapping is recommended.
> > + */
>
> Now that I re-read the comment, I think this can be postponed until we get a
> consensus that no new driver is ever should do non 1:1 mapping.
>
> If that consensus achieved, we may drop this enum altogether and replace it
> with the generic flags..
We don't keep things with no users. We can move this back if there ever
is a user.
Rob
next prev parent reply other threads:[~2023-01-13 20:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 14:51 [PATCH v1 1/1] gpiolib: of: Move enum of_gpio_flags to its only user Andy Shevchenko
2023-01-12 16:22 ` Andy Shevchenko
2023-01-13 20:23 ` Rob Herring [this message]
2023-01-13 21:19 ` Andy Shevchenko
2023-01-13 20:28 ` Rob Herring
2023-01-26 14:46 ` Arnd Bergmann
2023-01-27 8:49 ` Andy Shevchenko
2023-01-27 9:16 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230113202351.GA2864676-robh@kernel.org \
--to=robh@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=frowand.list@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).