From: Nikita Shubin <nikita.shubin@maquefel.me>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Hartley Sweeten" <hsweeten@visionengravers.com>,
"Alexander Sverdlin" <alexander.sverdlin@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Lukasz Majewski" <lukma@denx.de>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] gpio: ep93xx: convert driver to DT
Date: Wed, 25 Jan 2023 11:33:11 +0300 [thread overview]
Message-ID: <20230125113311.2aff259d@redslave.neermore.group> (raw)
In-Reply-To: <a699e52a-db19-4374-a4bc-a3948ecc43ef@app.fastmail.com>
Hello Arnd!
On Tue, 17 Jan 2023 11:15:20 +0100
"Arnd Bergmann" <arnd@arndb.de> wrote:
> On Tue, Jan 17, 2023, at 11:08, Nikita Shubin wrote:
>
> >
> > +#ifdef CONFIG_OF
> > +static const struct of_device_id ep93xx_gpio_match[] = {
> > + { .compatible = "cirrus,ep93xx-gpio" },
> > + { /* end of table */ },
> > +};
> > +MODULE_DEVICE_TABLE(of, ep93xx_gpio_match);
> > +#endif
> > +
> > static struct platform_driver ep93xx_gpio_driver = {
> > .driver = {
> > .name = "gpio-ep93xx",
> > + .of_match_table = ep93xx_gpio_match,
> > },
> > .probe = ep93xx_gpio_probe,
>
> The #ifdef here is wrong and will cause a build failure because
> of the unconditional reference to the variable.
>
> Just remove the #ifdef/#endif.
Sorry about that - i remember that i should drop it everywhere, which
did for all but ep93xx-gpio, i am dropping match currently, as it will
produce a warning without dt-bindings documentation, it will be
introduced together with the rest of series.
>
> Arnd
next prev parent reply other threads:[~2023-01-25 8:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 10:08 [PATCH 1/2] gpio: ep93xx: convert driver to DT Nikita Shubin
2023-01-17 10:08 ` [PATCH 2/2] gpio: ep93xx: Make irqchip immutable Nikita Shubin
2023-01-17 10:15 ` [PATCH 1/2] gpio: ep93xx: convert driver to DT Arnd Bergmann
2023-01-25 8:33 ` Nikita Shubin [this message]
2023-01-18 14:24 ` Bartosz Golaszewski
2023-01-25 8:30 ` [PATCH v1 0/3] gpio-ep93xx: prepare for dt, fixes Nikita Shubin
2023-01-25 8:30 ` [PATCH v1 1/3] gpio: ep93xx: Fix port F hwirq numbers in handler Nikita Shubin
2023-01-25 9:39 ` Arnd Bergmann
2023-01-25 12:42 ` Bartosz Golaszewski
2023-01-25 8:30 ` [PATCH v1 2/3] gpio: ep93xx: Make irqchip immutable Nikita Shubin
2023-01-25 12:45 ` Bartosz Golaszewski
2023-01-25 8:30 ` [PATCH v1 3/3] gpio: ep93xx: split device in multiple Nikita Shubin
2023-01-30 15:16 ` Bartosz Golaszewski
2023-02-01 9:10 ` [PATCH v2] " Nikita Shubin
2023-02-01 9:12 ` Bartosz Golaszewski
2023-02-01 9:18 ` Alexander Sverdlin
2023-02-01 9:26 ` Nikita Shubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125113311.2aff259d@redslave.neermore.group \
--to=nikita.shubin@maquefel.me \
--cc=alexander.sverdlin@gmail.com \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=hsweeten@visionengravers.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukma@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).