From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82E98C61D97 for ; Thu, 26 Jan 2023 14:12:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229579AbjAZOMx (ORCPT ); Thu, 26 Jan 2023 09:12:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229696AbjAZOMw (ORCPT ); Thu, 26 Jan 2023 09:12:52 -0500 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BE5B7DBE; Thu, 26 Jan 2023 06:12:49 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 600BEE0002; Thu, 26 Jan 2023 14:12:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674742368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=apF64NQiPjd6Pbr1s+6HUnhFlM+3Mq22SH9S9MZDcH8=; b=hnH9mwjYFt2M2tI9JelUob400f+76ivnks2/saJ8ZpdQc+zTj4qyrgYZEMPXdRzMzN5qZH /vaIMaWI98Xl2wzS8/K8DldzGDCAY2CKRPlaFCfHe222zDuqx0ephF3BvPFVMDDQltfnLX dbuDNb3Y1O3ajRXp1wcPDupk7o9J2sGefDkYeXMYwkugkrya+VaLQDr4f5cxJmTVmosF1o FCSQMi3mXQd6f3JJ3eIjRHGq/eaVsxAdd+ZefJJfRlcXW+8Ulp5IOsLkChFOZxKgi9frog 3g+OcFgw+dSqjrnqVAG8cnJ/IcICfZQDmyNoF4/+AOYnZ/aIKNejkycmxVobnw== Date: Thu, 26 Jan 2023 15:12:43 +0100 From: Miquel Raynal To: Arnd Bergmann Cc: Alexander Aring , Stefan Schmidt , linux-gpio@vger.kernel.org, Arnd Bergmann , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andy Shevchenko , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , linux-wpan@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] at86rf230: convert to gpio descriptors Message-ID: <20230126151243.3acc1fe2@xps-13> In-Reply-To: <20230126135215.3387820-1-arnd@kernel.org> References: <20230126135215.3387820-1-arnd@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Arnd, arnd@kernel.org wrote on Thu, 26 Jan 2023 14:51:23 +0100: > From: Arnd Bergmann >=20 > There are no remaining in-tree users of the platform_data, > so this driver can be converted to using the simpler gpiod > interfaces. >=20 > Any out-of-tree users that rely on the platform data can > provide the data using the device_property and gpio_lookup > interfaces instead. >=20 > Signed-off-by: Arnd Bergmann > --- > drivers/net/ieee802154/at86rf230.c | 82 +++++++++--------------------- > include/linux/spi/at86rf230.h | 20 -------- > 2 files changed, 25 insertions(+), 77 deletions(-) > delete mode 100644 include/linux/spi/at86rf230.h >=20 [...] > @@ -1682,7 +1650,7 @@ MODULE_DEVICE_TABLE(spi, at86rf230_device_id); > static struct spi_driver at86rf230_driver =3D { > .id_table =3D at86rf230_device_id, > .driver =3D { > - .of_match_table =3D of_match_ptr(at86rf230_of_match), > + .of_match_table =3D at86rf230_of_match,linux-gnueabihf embed a C libra= ry which relies on kernel headers (for example, to provide an open API whic= h translates to an open syscall), for exam Looks like an unrelated change? Or is it a consequence of "not having any in-tree users of platform_data" that plays a role here? Anyhow, the changes in the driver look good, so: Reviewed-by: Miquel Raynal Thanks, Miqu=C3=A8l