From: Nikita Shubin <nikita.shubin@maquefel.me>
To: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
Hartley Sweeten <hsweeten@visionengravers.com>,
Russell King <linux@armlinux.org.uk>,
Lukasz Majewski <lukma@denx.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2] gpio: ep93xx: split device in multiple
Date: Wed, 1 Feb 2023 12:26:28 +0300 [thread overview]
Message-ID: <20230201122628.2e4e1788@redslave.neermore.group> (raw)
In-Reply-To: <15f7dcbcdaf6fdb05bfc1d5bee1bb2e1bf3c43fc.camel@gmail.com>
On Wed, 01 Feb 2023 10:18:47 +0100
Alexander Sverdlin <alexander.sverdlin@gmail.com> wrote:
> Hello Nikita,
>
> On Wed, 2023-02-01 at 12:10 +0300, Nikita Shubin wrote:
> > This prepares ep93xx SOC gpio to convert into device tree driver:
> > - dropped banks and legacy defines
> > - split AB IRQ and make it shared
> >
> > We are relying on IRQ number information A, B ports have single
> > shared IRQ, while F port have dedicated IRQ for each line.
> >
> > Also we had to split single ep93xx platform_device into multiple,
> > one for each port, without this we can't do a full working
> > transition from legacy platform code into device tree capable. All
> > GPIO_LOOKUP were change to match new chip namings.
> >
> > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > Bart, i've rebased on the top of gpio/for-next (there were issues
> > indeed), but this patch still won't apply. That's becouse it's
> > dependant on Linus patch:
> > https://lore.kernel.org/linux-arm-kernel/20230111132210.134478-1-linus.walleij@linaro.org/T/
> >
> > Alexander can we have Linus patch somehow applied to ep93xx ?
>
> in contrast to me Linus and Bartosz do maintain their GPIO tree,
> from my side I've performed a quick test, so it's OK from my PoV to
> apply, but I cannot really assist here more.
>
Oh sorry about that, i thought if it refers to
"arch/arm/mach-ep93xx/core.c" - you or Hartley should apply them.
> Linus and Bartosz do maintain their GPIO tree
Then it should already exist in gpio/for-next ;).
```
echo heartbeat > /sys/class/leds/platform\:grled/trigger
echo heartbeat > /sys/class/leds/platform\:rdled/trigger
```
Both working on my ts7250.
prev parent reply other threads:[~2023-02-01 9:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 10:08 [PATCH 1/2] gpio: ep93xx: convert driver to DT Nikita Shubin
2023-01-17 10:08 ` [PATCH 2/2] gpio: ep93xx: Make irqchip immutable Nikita Shubin
2023-01-17 10:15 ` [PATCH 1/2] gpio: ep93xx: convert driver to DT Arnd Bergmann
2023-01-25 8:33 ` Nikita Shubin
2023-01-18 14:24 ` Bartosz Golaszewski
2023-01-25 8:30 ` [PATCH v1 0/3] gpio-ep93xx: prepare for dt, fixes Nikita Shubin
2023-01-25 8:30 ` [PATCH v1 1/3] gpio: ep93xx: Fix port F hwirq numbers in handler Nikita Shubin
2023-01-25 9:39 ` Arnd Bergmann
2023-01-25 12:42 ` Bartosz Golaszewski
2023-01-25 8:30 ` [PATCH v1 2/3] gpio: ep93xx: Make irqchip immutable Nikita Shubin
2023-01-25 12:45 ` Bartosz Golaszewski
2023-01-25 8:30 ` [PATCH v1 3/3] gpio: ep93xx: split device in multiple Nikita Shubin
2023-01-30 15:16 ` Bartosz Golaszewski
2023-02-01 9:10 ` [PATCH v2] " Nikita Shubin
2023-02-01 9:12 ` Bartosz Golaszewski
2023-02-01 9:18 ` Alexander Sverdlin
2023-02-01 9:26 ` Nikita Shubin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230201122628.2e4e1788@redslave.neermore.group \
--to=nikita.shubin@maquefel.me \
--cc=alexander.sverdlin@gmail.com \
--cc=brgl@bgdev.pl \
--cc=hsweeten@visionengravers.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukma@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).