From: Michael Walle <michael@walle.cc>
To: tharunkumar.pasumarthi@microchip.com
Cc: gregkh@linuxfoundation.org, UNGLinuxDriver@microchip.com,
arnd@arndb.de, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Michael Walle <michael@walle.cc>
Subject: Re: [PATCH v5 char-misc-next] misc: microchip: pci1xxxx: Add OTP/EEPROM driver for the pci1xxxx switch
Date: Mon, 13 Feb 2023 13:00:09 +0100 [thread overview]
Message-ID: <20230213120009.2661528-1-michael@walle.cc> (raw)
In-Reply-To: <Y+iQnfR65M0El34R@kroah.com>
>>> + /* Wait for the EPC_BUSY bit to get cleared */
>>> + do {
>>> + data = readl(priv->reg_base + MMAP_EEPROM_OFFSET(EEPROM_CMD_REG));
>>> + } while (data & EEPROM_CMD_EPC_BUSY_BIT);
>>
>> Again, you can not sit and spin in a busy-wait like this with no chance
>> to recover if something goes wrong with the hardware (hint, what if it
>> got removed?)
Also, it is good practice to CC people who did comments on the
former versions.
-michael
next prev parent reply other threads:[~2023-02-13 12:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 3:57 [PATCH v5 char-misc-next] misc: microchip: pci1xxxx: Add OTP/EEPROM driver for the pci1xxxx switch Tharun Kumar P
2023-02-12 7:09 ` Greg KH
2023-02-12 7:52 ` Tharunkumar.Pasumarthi
2023-02-13 12:00 ` Michael Walle [this message]
2023-02-14 6:25 ` Tharunkumar.Pasumarthi
2023-02-12 8:02 ` Christophe JAILLET
2023-02-14 6:37 ` Tharunkumar.Pasumarthi
2023-02-14 6:52 ` Tharunkumar.Pasumarthi
2023-02-14 8:28 ` Michael Walle
2023-02-15 4:37 ` Kumaravel.Thiagarajan
2023-02-15 8:20 ` Michael Walle
2023-02-15 8:58 ` Greg KH
2023-02-15 9:48 ` Kumaravel.Thiagarajan
2023-02-15 9:56 ` Kumaravel.Thiagarajan
2023-02-15 10:15 ` Michael Walle
2023-02-15 11:44 ` Greg KH
2023-02-16 11:39 ` Kumaravel.Thiagarajan
2023-02-16 11:49 ` Greg KH
2023-02-17 8:57 ` Kumaravel.Thiagarajan
2023-02-17 9:22 ` Greg KH
2023-02-20 9:31 ` Kumaravel.Thiagarajan
2023-02-20 9:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230213120009.2661528-1-michael@walle.cc \
--to=michael@walle.cc \
--cc=UNGLinuxDriver@microchip.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tharunkumar.pasumarthi@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).