From: Michael Walle <michael@walle.cc>
To: kumaravel.thiagarajan@microchip.com
Cc: UNGLinuxDriver@microchip.com, arnd@arndb.de,
derek.kiernan@xilinx.com, dragan.cvetic@xilinx.com,
gregkh@linuxfoundation.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Michael Walle <michael@walle.cc>
Subject: Re: [PATCH v1 char-misc-next 2/5] misc: microchip: pci1xxxx: load gpio driver for the gpio controller auxiliary device enumerated by the auxiliary bus driver.
Date: Fri, 17 Feb 2023 11:31:16 +0100 [thread overview]
Message-ID: <20230217103116.2126311-1-michael@walle.cc> (raw)
In-Reply-To: <20220824200047.150308-3-kumaravel.thiagarajan@microchip.com>
[+ GPIO maintainers]
> PIO function's auxiliary bus driver enumerates separate child devices for
> GPIO controller and OTP/EEPROM interface. This gpio driver implemented
> based on the gpio framework is loaded for the gpio auxiliary device.
>
> Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
> ---
> MAINTAINERS | 1 +
> drivers/misc/mchp_pci1xxxx/Makefile | 2 +-
> .../misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c | 163 ++++++++++++++++++
Why doesn't this file live in the GPIO subsystem? Seems like this haven't
got a proper review from the GPIO people (probably due to the "misc:"
subject). Maybe even GPIO_REGMAP could be used.
-michael
next prev parent reply other threads:[~2023-02-17 10:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 20:00 [PATCH v1 char-misc-next 0/5] misc: microchip: pci1xxxx: Add auxiliary bus driver and the GPIO driver for PIO function of pci1xxxx Kumaravel Thiagarajan
2022-08-24 20:00 ` [PATCH v1 char-misc-next 1/5] misc: microchip: pci1xxxx: load auxiliary bus driver for the PIO function in the multi-function endpoint of pci1xxxx device Kumaravel Thiagarajan
2022-08-24 20:00 ` [PATCH v1 char-misc-next 2/5] misc: microchip: pci1xxxx: load gpio driver for the gpio controller auxiliary device enumerated by the auxiliary bus driver Kumaravel Thiagarajan
2023-02-17 10:31 ` Michael Walle [this message]
2023-02-23 10:23 ` Linus Walleij
2023-02-23 10:29 ` Michael Walle
2022-08-24 20:00 ` [PATCH v1 char-misc-next 3/5] misc: microchip: pci1xxxx: Add functions to configure gpio pins as input / output, get status, handle I/O for gpio pins Kumaravel Thiagarajan
2022-08-24 20:00 ` [PATCH v1 char-misc-next 4/5] misc: microchip: pci1xxxx: Add gpio irq handler and irq helper functions irq_ack, irq_mask, irq_unmask and irq_set_type of irq_chip Kumaravel Thiagarajan
2022-08-24 20:00 ` [PATCH v1 char-misc-next 5/5] misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers Kumaravel Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230217103116.2126311-1-michael@walle.cc \
--to=michael@walle.cc \
--cc=UNGLinuxDriver@microchip.com \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=derek.kiernan@xilinx.com \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=kumaravel.thiagarajan@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).