From: Keguang Zhang <keguang.zhang@gmail.com>
To: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Keguang Zhang <keguang.zhang@gmail.com>
Subject: [PATCH 3/4] gpio: loongson1: Add DT support
Date: Wed, 22 Feb 2023 19:12:12 +0800 [thread overview]
Message-ID: <20230222111213.2241633-4-keguang.zhang@gmail.com> (raw)
In-Reply-To: <20230222111213.2241633-1-keguang.zhang@gmail.com>
This patch adds DT support for Loongson-1 GPIO driver,
including the following changes.
- Add the of_match_table
- Parse the ngpios property
- Parse the alias id
Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
---
drivers/gpio/gpio-loongson1.c | 31 ++++++++++++++++++++++++++++---
1 file changed, 28 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-loongson1.c b/drivers/gpio/gpio-loongson1.c
index b950bcfd78ce..92ad31f61bf0 100644
--- a/drivers/gpio/gpio-loongson1.c
+++ b/drivers/gpio/gpio-loongson1.c
@@ -48,7 +48,10 @@ static void ls1x_gpio_free(struct gpio_chip *gc, unsigned int offset)
static int ls1x_gpio_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
+ struct device_node *dn = pdev->dev.of_node;
struct ls1x_gpio_chip *ls1x_gc;
+ unsigned int ngpios;
+ int id;
int ret;
ls1x_gc = devm_kzalloc(dev, sizeof(*ls1x_gc), GFP_KERNEL);
@@ -59,34 +62,56 @@ static int ls1x_gpio_probe(struct platform_device *pdev)
if (IS_ERR(ls1x_gc->reg_base))
return PTR_ERR(ls1x_gc->reg_base);
+ if (of_property_read_u32(dn, "ngpios", &ngpios)) {
+ dev_err(dev, "Missing ngpios OF property\n");
+ return -ENODEV;
+ }
+
+ id = of_alias_get_id(dn, "gpio");
+ if (id < 0) {
+ dev_err(dev, "Couldn't get OF id\n");
+ return id;
+ }
+
ret = bgpio_init(&ls1x_gc->gc, dev, 4, ls1x_gc->reg_base + GPIO_DATA,
ls1x_gc->reg_base + GPIO_OUTPUT, NULL,
NULL, ls1x_gc->reg_base + GPIO_DIR, 0);
if (ret)
goto err;
+ ls1x_gc->gc.label = dev_name(&pdev->dev);
+ ls1x_gc->gc.ngpio = ngpios;
ls1x_gc->gc.owner = THIS_MODULE;
+ ls1x_gc->gc.parent = dev;
+ ls1x_gc->gc.base = pdev->id * BITS_PER_LONG;
ls1x_gc->gc.request = ls1x_gpio_request;
ls1x_gc->gc.free = ls1x_gpio_free;
- ls1x_gc->gc.base = pdev->id * 32;
ret = devm_gpiochip_add_data(dev, &ls1x_gc->gc, ls1x_gc);
if (ret)
goto err;
platform_set_drvdata(pdev, ls1x_gc);
- dev_info(dev, "Loongson1 GPIO driver registered\n");
+
+ dev_info(dev, "GPIO controller %d registered with %d pins\n", id,
+ ngpios);
return 0;
err:
- dev_err(dev, "failed to register GPIO device\n");
+ dev_err(dev, "failed to register GPIO controller\n");
return ret;
}
+static const struct of_device_id ls1x_gpio_dt_ids[] = {
+ { .compatible = "loongson,ls1x-gpio", },
+ { /* sentinel */ }
+};
+
static struct platform_driver ls1x_gpio_driver = {
.probe = ls1x_gpio_probe,
.driver = {
.name = "ls1x-gpio",
+ .of_match_table = ls1x_gpio_dt_ids,
},
};
--
2.34.1
next prev parent reply other threads:[~2023-02-22 11:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 11:12 [PATCH 0/4] Devicetree support for Loongson-1 GPIO Keguang Zhang
2023-02-22 11:12 ` [PATCH 1/4] gpio: loongson1: Update copyright Keguang Zhang
2023-02-22 12:17 ` andy.shevchenko
2023-03-02 11:09 ` Kelvin Cheung
2023-03-02 11:40 ` Krzysztof Kozlowski
2023-03-02 12:16 ` Kelvin Cheung
2023-03-02 19:02 ` Andy Shevchenko
2023-02-22 11:12 ` [PATCH 2/4] gpio: loongson1: Introduce ls1x_gpio_chip struct Keguang Zhang
2023-02-22 12:18 ` andy.shevchenko
2023-03-02 11:11 ` Kelvin Cheung
2023-02-22 11:12 ` Keguang Zhang [this message]
2023-02-22 12:20 ` [PATCH 3/4] gpio: loongson1: Add DT support andy.shevchenko
2023-03-02 11:08 ` Kelvin Cheung
2023-02-22 11:12 ` [PATCH 4/4] dt-bindings: gpio: Add Loongson-1 GPIO Keguang Zhang
2023-02-22 12:35 ` Krzysztof Kozlowski
2023-03-01 9:50 ` Kelvin Cheung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222111213.2241633-4-keguang.zhang@gmail.com \
--to=keguang.zhang@gmail.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).