From: Keguang Zhang <keguang.zhang@gmail.com>
To: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Keguang Zhang <keguang.zhang@gmail.com>
Subject: [PATCH v2 4/5] gpio: loongson1: Add DT support
Date: Thu, 2 Mar 2023 20:52:14 +0800 [thread overview]
Message-ID: <20230302125215.214014-5-keguang.zhang@gmail.com> (raw)
In-Reply-To: <20230302125215.214014-1-keguang.zhang@gmail.com>
This patch adds DT support for Loongson-1 GPIO driver.
Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
---
V1 -> V2: Let gpiolib parse ngpios property
Remove unnecessary alias id parsing
Remove superfluous initialization done by bgpio_init()
Add MODULE_DEVICE_TABLE()
Other minor fixes
---
drivers/gpio/gpio-loongson1.c | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-loongson1.c b/drivers/gpio/gpio-loongson1.c
index 3ac9e49e7efb..94ac0ccb450f 100644
--- a/drivers/gpio/gpio-loongson1.c
+++ b/drivers/gpio/gpio-loongson1.c
@@ -68,25 +68,38 @@ static int ls1x_gpio_probe(struct platform_device *pdev)
ls1x_gc->gc.owner = THIS_MODULE;
ls1x_gc->gc.request = ls1x_gpio_request;
ls1x_gc->gc.free = ls1x_gpio_free;
- ls1x_gc->gc.base = pdev->id * 32;
+ /*
+ * Clear ngpio to let gpiolib get the correct number
+ * by reading ngpios property
+ */
+ ls1x_gc->gc.ngpio = 0;
ret = devm_gpiochip_add_data(dev, &ls1x_gc->gc, ls1x_gc);
if (ret)
goto err;
platform_set_drvdata(pdev, ls1x_gc);
- dev_info(dev, "Loongson1 GPIO driver registered\n");
+
+ dev_info(dev, "GPIO controller registered with %d pins\n",
+ ls1x_gc->gc.ngpio);
return 0;
err:
- dev_err(dev, "failed to register GPIO device\n");
+ dev_err(dev, "failed to register GPIO controller\n");
return ret;
}
+static const struct of_device_id ls1x_gpio_dt_ids[] = {
+ { .compatible = "loongson,ls1x-gpio" },
+ { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, ls1x_gpio_dt_ids);
+
static struct platform_driver ls1x_gpio_driver = {
.probe = ls1x_gpio_probe,
.driver = {
.name = "ls1x-gpio",
+ .of_match_table = ls1x_gpio_dt_ids,
},
};
--
2.34.1
next prev parent reply other threads:[~2023-03-02 12:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 12:52 [PATCH v2 0/5] Devicetree support for Loongson-1 GPIO Keguang Zhang
2023-03-02 12:52 ` [PATCH v2 1/5] gpio: loongson1: Convert to SPDX identifier Keguang Zhang
2023-03-06 9:29 ` Bartosz Golaszewski
2023-03-07 2:25 ` Keguang Zhang
2023-03-07 13:31 ` Linus Walleij
2023-03-08 2:46 ` Keguang Zhang
2023-03-07 16:48 ` Bartosz Golaszewski
2023-03-08 2:53 ` Keguang Zhang
2023-03-02 12:52 ` [PATCH v2 2/5] gpio: loongson1: Use readl() & writel() Keguang Zhang
2023-03-06 9:30 ` Bartosz Golaszewski
2023-03-07 3:45 ` Keguang Zhang
2023-03-08 9:42 ` David Laight
2023-03-08 11:35 ` Keguang Zhang
2023-03-02 12:52 ` [PATCH v2 3/5] gpio: loongson1: Introduce ls1x_gpio_chip struct Keguang Zhang
2023-03-02 12:52 ` Keguang Zhang [this message]
2023-03-06 9:39 ` [PATCH v2 4/5] gpio: loongson1: Add DT support Bartosz Golaszewski
2023-03-07 3:41 ` Keguang Zhang
2023-03-02 12:52 ` [PATCH v2 5/5] dt-bindings: gpio: Add Loongson-1 GPIO Keguang Zhang
2023-03-02 12:58 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302125215.214014-5-keguang.zhang@gmail.com \
--to=keguang.zhang@gmail.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).