linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Schspa Shi <schspa@gmail.com>, Marc Zyngier <maz@kernel.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	patches@opensource.cirrus.com
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"Doug Berger" <opendmb@gmail.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Kuppuswamy Sathyanarayanan"
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	"Nandor Han" <nandor.han@ge.com>,
	"Semi Malinen" <semi.malinen@ge.com>
Subject: [PATCH v1 10/16] gpio: mvebu: Utilize helpers from string_choices.h
Date: Mon,  6 Mar 2023 21:55:50 +0200	[thread overview]
Message-ID: <20230306195556.55475-11-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20230306195556.55475-1-andriy.shevchenko@linux.intel.com>

There are a few helpers available to convert a boolean variable
to the dedicated string literals depending on the application.
Use them in the driver.

While at, utilize specifier field for padding the strings where
it's required.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpio-mvebu.c | 27 ++++++++++++---------------
 1 file changed, 12 insertions(+), 15 deletions(-)

diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
index a68f682aec01..f2bbe928577c 100644
--- a/drivers/gpio/gpio-mvebu.c
+++ b/drivers/gpio/gpio-mvebu.c
@@ -48,6 +48,7 @@
 #include <linux/pwm.h>
 #include <linux/regmap.h>
 #include <linux/slab.h>
+#include <linux/string_choices.h>
 
 /*
  * GPIO unit register offsets.
@@ -897,32 +898,28 @@ static void mvebu_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
 	lvl_msk	= mvebu_gpio_read_level_mask(mvchip);
 
 	for_each_requested_gpio(chip, i, label) {
-		u32 msk;
-		bool is_out;
+		u32 msk = BIT(i);
 
-		msk = BIT(i);
-		is_out = !(io_conf & msk);
+		seq_printf(s, " gpio-%-3d (%-20.20s) %-3.3s ", chip->base + i, label,
+			   str_in_out(io_conf & msk));
 
-		seq_printf(s, " gpio-%-3d (%-20.20s)", chip->base + i, label);
-
-		if (is_out) {
-			seq_printf(s, " out %s %s\n",
-				   out & msk ? "hi" : "lo",
+		if (!(io_conf & msk)) {
+			seq_printf(s, "%-2.2s %s\n", str_hi_lo(out & msk),
 				   blink & msk ? "(blink )" : "");
 			continue;
 		}
 
-		seq_printf(s, " in  %s (act %s) - IRQ",
-			   (data_in ^ in_pol) & msk  ? "hi" : "lo",
-			   in_pol & msk ? "lo" : "hi");
+		seq_printf(s, "%-2.2s (act %-2.2s) - IRQ ",
+			   str_hi_lo((data_in ^ in_pol) & msk),
+			   str_lo_hi(in_pol & msk));
 		if (!((edg_msk | lvl_msk) & msk)) {
-			seq_puts(s, " disabled\n");
+			seq_puts(s, "disabled\n");
 			continue;
 		}
 		if (edg_msk & msk)
-			seq_puts(s, " edge ");
+			seq_puts(s, "edge ");
 		if (lvl_msk & msk)
-			seq_puts(s, " level");
+			seq_puts(s, "level");
 		seq_printf(s, " (%s)\n", cause & msk ? "pending" : "clear  ");
 	}
 }
-- 
2.39.1


  parent reply	other threads:[~2023-03-06 19:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 19:55 [PATCH v1 00/16] gpio: Use string_choices.h Andy Shevchenko
2023-03-06 19:55 ` [PATCH v1 01/16] lib/string_helpers: Add missing header files to MAINTAINERS database Andy Shevchenko
2023-03-06 19:55 ` [PATCH v1 02/16] lib/string_helpers: Split out string_choices.h Andy Shevchenko
2023-03-06 19:55 ` [PATCH v1 03/16] lib/string_choices: Add str_high_low() helper Andy Shevchenko
2023-03-06 19:55 ` [PATCH v1 04/16] lib/string_choices: Add str_input_output() helper Andy Shevchenko
2023-03-06 19:55 ` [PATCH v1 05/16] gpiolib: Utilize helpers from string_choices.h Andy Shevchenko
2023-03-06 19:55 ` [PATCH v1 06/16] gpio: adnp: " Andy Shevchenko
2023-03-06 19:55 ` [PATCH v1 07/16] gpio: brcmstb: " Andy Shevchenko
2023-03-06 19:57   ` Florian Fainelli
2023-03-06 19:55 ` [PATCH v1 08/16] gpio: crystalcove: " Andy Shevchenko
2023-03-06 19:55 ` [PATCH v1 09/16] gpio: grgpio: " Andy Shevchenko
2023-03-06 19:55 ` Andy Shevchenko [this message]
2023-03-06 19:55 ` [PATCH v1 11/16] gpio: pl061: " Andy Shevchenko
2023-03-06 19:55 ` [PATCH v1 12/16] gpio: stmpe: " Andy Shevchenko
2023-03-06 19:55 ` [PATCH v1 13/16] gpio: wcove: " Andy Shevchenko
2023-03-06 20:28   ` Sathyanarayanan Kuppuswamy
2023-03-06 19:55 ` [PATCH v1 14/16] gpio: wm831x: " Andy Shevchenko
2023-03-07 11:35   ` Charles Keepax
2023-03-06 19:55 ` [PATCH v1 15/16] gpio: wm8994: " Andy Shevchenko
2023-03-07 11:36   ` Charles Keepax
2023-03-06 19:55 ` [PATCH v1 16/16] gpio: xra1403: " Andy Shevchenko
2023-03-06 20:25 ` [PATCH v1 00/16] gpio: Use string_choices.h Andy Shevchenko
2023-03-09 15:22 ` Bartosz Golaszewski
2023-03-10  7:32   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230306195556.55475-11-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andy@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=brgl@bgdev.pl \
    --cc=f.fainelli@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=maz@kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=nandor.han@ge.com \
    --cc=opendmb@gmail.com \
    --cc=patches@opensource.cirrus.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=schspa@gmail.com \
    --cc=semi.malinen@ge.com \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).