From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: [PATCH v1 1/3] gpiolib: Access device's fwnode via dev_fwnode()
Date: Tue, 7 Mar 2023 20:25:55 +0200 [thread overview]
Message-ID: <20230307182557.42215-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20230307182557.42215-1-andriy.shevchenko@linux.intel.com>
GPIO device's fwnode should be accessed via dev_fwnode().
Make sure that gpiochip_setup_dev() follows that.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpio/gpiolib.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index b554ad435245..c7f35f0e7d15 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -589,14 +589,15 @@ static void gpiodevice_release(struct device *dev)
static int gpiochip_setup_dev(struct gpio_device *gdev)
{
+ struct fwnode_handle *fwnode = dev_fwnode(&gdev->dev);
int ret;
/*
* If fwnode doesn't belong to another device, it's safe to clear its
* initialized flag.
*/
- if (gdev->dev.fwnode && !gdev->dev.fwnode->dev)
- fwnode_dev_initialized(gdev->dev.fwnode, false);
+ if (fwnode && !fwnode->dev)
+ fwnode_dev_initialized(fwnode, false);
ret = gcdev_register(gdev, gpio_devt);
if (ret)
--
2.39.1
next prev parent reply other threads:[~2023-03-07 18:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 18:25 [PATCH v1 0/3] gpiolib: cleanups WRT GPIO device handling Andy Shevchenko
2023-03-07 18:25 ` Andy Shevchenko [this message]
2023-03-09 13:58 ` [PATCH v1 1/3] gpiolib: Access device's fwnode via dev_fwnode() Linus Walleij
2023-03-07 18:25 ` [PATCH v1 2/3] gpiolib: Get rid of gpio_bus_match() forward declaration Andy Shevchenko
2023-03-09 13:58 ` Linus Walleij
2023-03-07 18:25 ` [PATCH v1 3/3] gpiolib: Move gpiodevice_*() to gpiodev namespace Andy Shevchenko
2023-03-08 10:49 ` Bartosz Golaszewski
2023-03-09 18:52 ` Andy Shevchenko
2023-03-10 16:48 ` Bartosz Golaszewski
2023-03-10 17:01 ` Andy Shevchenko
2023-03-15 9:44 ` Bartosz Golaszewski
2023-03-08 10:50 ` [PATCH v1 0/3] gpiolib: cleanups WRT GPIO device handling Bartosz Golaszewski
2023-03-08 13:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307182557.42215-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).