From: Nishanth Menon <nm@ti.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Sekhar Nori <nsekhar@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
<linux-gpio@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<netdev@vger.kernel.org>, Tero Kristo <kristo@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 2/2] dt-bindings: pinctrl: Move k3.h to arch
Date: Mon, 13 Mar 2023 11:00:19 -0500 [thread overview]
Message-ID: <20230313160019.vask6atfs6qwphml@twerp> (raw)
In-Reply-To: <71c7feff-4189-f12f-7353-bce41a61119d@linaro.org>
On 16:46-20230311, Krzysztof Kozlowski wrote:
> On 11/03/2023 14:13, Nishanth Menon wrote:
> > Move the k3 pinctrl definition to arch dts folder.
> >
> > While at this, fixup MAINTAINERS and header guard macro to better
> > reflect the changes.
> >
> > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Suggested-by: Linus Walleij <linus.walleij@linaro.org>
> > Link: https://lore.kernel.org/all/c4d53e9c-dac0-8ccc-dc86-faada324beba@linaro.org/
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> > ---
> >
> > There is no specific case I can think of at the moment to create a
> > pinctrl.dtsi for the SoCs.. So, unlike other SoCs, I had not done that
> > in the series, if folks have a better opinion about this, please let us
> > discuss.
> >
> > MAINTAINERS | 1 -
> > arch/arm64/boot/dts/ti/k3-am62.dtsi | 3 ++-
> > arch/arm64/boot/dts/ti/k3-am62a.dtsi | 3 ++-
> > arch/arm64/boot/dts/ti/k3-am64.dtsi | 3 ++-
> > arch/arm64/boot/dts/ti/k3-am65.dtsi | 3 ++-
> > arch/arm64/boot/dts/ti/k3-j7200.dtsi | 3 ++-
> > arch/arm64/boot/dts/ti/k3-j721e.dtsi | 3 ++-
> > arch/arm64/boot/dts/ti/k3-j721s2.dtsi | 3 ++-
> > arch/arm64/boot/dts/ti/k3-j784s4.dtsi | 3 ++-
> > .../pinctrl/k3.h => arch/arm64/boot/dts/ti/k3-pinctrl.h | 6 +++---
>
> Bindings are separate from other changes (also DTS). Split the patches.
>
> (...)
>
> > / {
> > model = "Texas Instruments K3 J784S4 SoC";
> > compatible = "ti,j784s4";
> > diff --git a/include/dt-bindings/pinctrl/k3.h b/arch/arm64/boot/dts/ti/k3-pinctrl.h
> > similarity index 94%
> > rename from include/dt-bindings/pinctrl/k3.h
> > rename to arch/arm64/boot/dts/ti/k3-pinctrl.h
> > index 469bd29651db..6004e0967ec5 100644
> > --- a/include/dt-bindings/pinctrl/k3.h
> > +++ b/arch/arm64/boot/dts/ti/k3-pinctrl.h
>
> Dropping this file is going to break existing code and I would say is
> also a break of the ABI. You need to keep the header for at least one
> cycle, you can add there a warning for coming deprecation.
>
> See for example:
> https://lore.kernel.org/all/20220605160508.134075-5-krzysztof.kozlowski@linaro.org/
Makes complete sense. Thanks. will follow the lead and redo the series.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
prev parent reply other threads:[~2023-03-13 16:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 13:13 [PATCH 0/2] dt-bindings: pinctrl: ti-k3: Move k3.h to arch specific Nishanth Menon
2023-03-11 13:13 ` [PATCH 1/2] dt-bindings: net: ti: k3-am654-cpsw-nuss: Drop pinmux header Nishanth Menon
2023-03-11 15:43 ` Krzysztof Kozlowski
2023-03-13 15:59 ` Nishanth Menon
2023-03-11 13:13 ` [PATCH 2/2] dt-bindings: pinctrl: Move k3.h to arch Nishanth Menon
2023-03-11 15:46 ` Krzysztof Kozlowski
2023-03-13 16:00 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230313160019.vask6atfs6qwphml@twerp \
--to=nm@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).