From: Lee Jones <lee@kernel.org>
To: "larry.lai" <larry.lai@yunjingtech.com>
Cc: andriy.shevchenko@linux.intel.com, linus.walleij@linaro.org,
pavel@ucw.cz, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-leds@vger.kernel.org,
GaryWang@aaeon.com.tw, musa.lin@yunjingtech.com,
jack.chang@yunjingtech.com, noah.hung@yunjingtech.com,
michael.wang@yunjingtech.com
Subject: Re: [RFC RESEND 3/3] leds: Add support for UP board CPLD onboard LEDS
Date: Thu, 27 Apr 2023 18:15:44 +0100 [thread overview]
Message-ID: <20230427171544.GF620451@google.com> (raw)
In-Reply-To: <20230425152135.30745-4-larry.lai@yunjingtech.com>
On Tue, 25 Apr 2023, larry.lai wrote:
> The UP boards come with a few FPGA-controlled onboard LEDs:
> * UP Board: yellow, green, red
> * UP Squared: blue, yellow, green, red
>
> This patch depends on patch "mfd: Add support for UP board CPLD/FPGA".
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Lee Jones <lee@kernel.org>
Definitely not. Please try again after reading:
Documentation/process/submitting-patches.rst
> Signed-off-by: larry.lai <larry.lai@yunjingtech.com>
> ---
> RFC 2022/11/23 --> RFC 2023/04/25: Refer 2022/12/08 Lee Jones review,
> cleaned up coding style.
> PATCH V3 -> RFC 2022/11/23: Update the changes Copyright.
> PATCH V1 -> V3: There is no change.
> PATCH --> PATCH V1: Refer 2022/10/03 Andy Shevchenko review, cleaned up
> coding style.
> ---
> ---
> drivers/leds/Kconfig | 10 +++++
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-upboard.c | 79 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 90 insertions(+)
> create mode 100644 drivers/leds/leds-upboard.c
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-04-27 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 15:21 [RFC RESEND 0/3] Add support control UP board CPLD/FPGA pin control larry.lai
2023-04-25 15:21 ` [RFC RESEND 1/3] mfd: Add support for UP board CPLD/FPGA larry.lai
2023-04-27 17:14 ` Lee Jones
2023-04-25 15:21 ` [RFC RESEND 2/3] pinctrl: Add support pin control " larry.lai
2023-04-25 15:21 ` [RFC RESEND 3/3] leds: Add support for UP board CPLD onboard LEDS larry.lai
2023-04-27 17:15 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427171544.GF620451@google.com \
--to=lee@kernel.org \
--cc=GaryWang@aaeon.com.tw \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jack.chang@yunjingtech.com \
--cc=larry.lai@yunjingtech.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=michael.wang@yunjingtech.com \
--cc=musa.lin@yunjingtech.com \
--cc=noah.hung@yunjingtech.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).